Issue 10825016: Fixed coverity defects regarding pass-by-value

Issue 10825016: Fixed coverity defects regarding pass-by-value (Closed)

Created:
8 years, 5 months ago by Oren Blasberg

Modified:
8 years, 5 months ago

Reviewers:
Kyle Horimoto

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed coverity defects pertaining to pass-by-value use where pass-by-reference is preferred CID_COUNT=3 CID=(104210, 104215),104237,104238 BUG= TEST= TBR=jln,bolms,brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148437

Patch Set 1 #

Patch Set 2 : Fixed non-compiling code caused by neglect to update header file #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	chrome/browser/extensions/shell_window_registry.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/shell_window_registry.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Kyle Horimoto

On 2012/07/25 19:01:50, orenb wrote: > Fixing coverity pass-by-value defects. LGTM

8 years, 5 months ago (2012-07-25 19:03:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/10825016/1

8 years, 5 months ago (2012-07-25 19:04:38 UTC) #3

commit-bot: I haz the power

Try job failure for 10825016-1 (retry) on android for steps "compile, build" (clobber build). It's ...

8 years, 5 months ago (2012-07-25 19:17:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/10825016/1

8 years, 5 months ago (2012-07-25 20:55:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/10825016/7002

8 years, 5 months ago (2012-07-25 20:57:18 UTC) #6

Change committed as 148437

Expand Messages | Collapse Messages