chrome/browser/extensions/shell_window_registry.cc - Issue 10825016: Fixed coverity defects regarding pass-by-value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shell_window_registry.cc

Issue 10825016: Fixed coverity defects regarding pass-by-value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed non-compiling code caused by neglect to update header file Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/shell_window_registry.cc

diff --git a/chrome/browser/extensions/shell_window_registry.cc b/chrome/browser/extensions/shell_window_registry.cc

index d852cffd6354d22834fa87f0a6e6f64f2fd0b099..e97138df3b96457e7c3d02410b7555d1d9153efa 100644

--- a/chrome/browser/extensions/shell_window_registry.cc

+++ b/chrome/browser/extensions/shell_window_registry.cc

@@ -37,7 +37,7 @@ void ShellWindowRegistry::RemoveObserver(Observer* observer) {

}

ShellWindowRegistry::ShellWindowSet ShellWindowRegistry::GetShellWindowsForApp(

- const std::string app_id) const {

+ const std::string& app_id) const {

ShellWindowSet app_windows;

for (ShellWindowSet::const_iterator i = shell_windows_.begin();

i != shell_windows_.end(); ++i) {