chrome/browser/extensions/shell_window_registry.h - Issue 10825016: Fixed coverity defects regarding pass-by-value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shell_window_registry.h

Issue 10825016: Fixed coverity defects regarding pass-by-value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed non-compiling code caused by neglect to update header file Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/shell_window_registry.h

diff --git a/chrome/browser/extensions/shell_window_registry.h b/chrome/browser/extensions/shell_window_registry.h

index 52f3e1f233460d13cb5b834320b786a76f9d720a..3e248cbc8acde92f8282f0af3aae46270766cc36 100644

--- a/chrome/browser/extensions/shell_window_registry.h

+++ b/chrome/browser/extensions/shell_window_registry.h

@@ -58,7 +58,7 @@ class ShellWindowRegistry : public ProfileKeyedService {

void RemoveObserver(Observer* observer);

// Returns a set of windows owned by the application identified by app_id.

- ShellWindowSet GetShellWindowsForApp(const std::string app_id) const;

+ ShellWindowSet GetShellWindowsForApp(const std::string& app_id) const;

const ShellWindowSet& shell_windows() const { return shell_windows_; }

// Helper functions to find shell windows with particular attributes.

« no previous file with comments | « no previous file | chrome/browser/extensions/shell_window_registry.cc » ('j') | no next file with comments »