Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10824295: Rid the world of the last of views::Event types: TouchEvent, GestureEvent, MouseWheelEvent, ScrollE… (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, mihaip-chromium-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, Randy Smith (Not in Mondays), dcheng, penghuang+watch_chromium.org, Aaron Boodman, James Su
Visibility:
Public.

Description

Rid the world of the last of views::Event types: TouchEvent, GestureEvent, MouseWheelEvent, ScrollEvent and DropTargetEvent, in favor of ui::Event derivatives. http://crbug.com/125937 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151602

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -943 lines) Patch
M ash/drag_drop/drag_drop_controller_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/launcher/launcher_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/overflow_bubble.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/tray_notification_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/partial_screenshot_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/partial_screenshot_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_tester.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/contents_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/contents_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/search_box_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/event.h View 6 chunks +64 lines, -28 lines 0 comments Download
M ui/base/event.cc View 3 chunks +45 lines, -4 lines 0 comments Download
M ui/base/event_unittest.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M ui/base/events.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/win/events_win.cc View 4 chunks +27 lines, -16 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/link.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/link.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/submenu_view.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M ui/views/controls/tree/tree_view_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/events/event.h View 1 chunk +0 lines, -207 lines 0 comments Download
D ui/views/events/event.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D ui/views/events/event_aura.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/views/events/event_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D ui/views/events/event_win.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/views/events/event_x.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M ui/views/focus/accelerator_handler_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/focus/focus_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/ime/input_method_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/ime/mock_input_method.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/view.h View 9 chunks +10 lines, -11 lines 0 comments Download
M ui/views/view.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M ui/views/view_unittest.cc View 14 chunks +44 lines, -30 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/widget/drop_helper.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/views/widget/root_view.cc View 9 chunks +13 lines, -9 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
8 years, 4 months ago (2012-08-14 19:45:55 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698