Issue 10824270: Revert 151153 - Partial revert of 146621

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824270: Revert 151153 - Partial revert of 146621 (Closed)

Created:
8 years, 4 months ago by simonmorris

Modified:
8 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, yusukes+watch_chromium.org, jonathan.backer, Ian Vollick, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 151153 - Partial revert of 146621 The original patch introduced a crash (GetCompositor() can return NULL), but reverting the whole thing is not possible without a lot of other reverts, and the proper fix is fairly involve (likely not reasonable to patch to the branch). This only reverts the problematic part, and a follow up will do a proper fix. BUG=141756 Review URL: https://chromiumcodereview.appspot.com/10828262 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151159

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -10 lines)			Patch
M	content/browser/renderer_host/image_transport_factory.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/image_transport_factory.cc	View	3 chunks	+20 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/compositor/compositor.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/compositor/layer.h	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	ui/compositor/layer.cc	View	3 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages