Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10828262: Partial revert of 146621 (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jonathan.backer, Ian Vollick, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su
Visibility:
Public.

Description

Partial revert of 146621 The original patch introduced a crash (GetCompositor() can return NULL), but reverting the whole thing is not possible without a lot of other reverts, and the proper fix is fairly involve (likely not reasonable to patch to the branch). This only reverts the problematic part, and a follow up will do a proper fix. BUG=141756 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151153 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151181

Patch Set 1 #

Patch Set 2 : fix win_aura bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -52 lines) Patch
M content/browser/renderer_host/image_transport_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 3 chunks +4 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer.h View 3 chunks +1 line, -8 lines 0 comments Download
M ui/compositor/layer.cc View 3 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
piman
8 years, 4 months ago (2012-08-10 18:49:43 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-10 19:02:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10828262/1
8 years, 4 months ago (2012-08-10 22:24:56 UTC) #3
commit-bot: I haz the power
Change committed as 151153
8 years, 4 months ago (2012-08-10 23:44:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10828262/2002
8 years, 4 months ago (2012-08-11 01:25:01 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-11 03:05:23 UTC) #6
Change committed as 151181

Powered by Google App Engine
This is Rietveld 408576698