Issue 10824240: gdata: Make callback parameters mandatory for TransferFile functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824240: gdata: Make callback parameters mandatory for TransferFile functions (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Make callback parameters mandatory for TransferFile functions The public functions TransferFileFromRemoteToLocal() and TransferFileFromLocalToRemote() are called from file_browser_private_api.cc with callbacks, hence it's safe to make the callback parameter mandatory. BUG=126634, 139446 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150896

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -21 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	5 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	7 chunks	+13 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_interface.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

achuithb

8 years, 4 months ago (2012-08-09 18:27:23 UTC) #2

lgtm++. I think this will make it easier to find failures.

Expand Messages | Collapse Messages