Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.h

Issue 10824240: gdata: Make callback parameters mandatory for TransferFile functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_file_system.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.h b/chrome/browser/chromeos/gdata/gdata_file_system.h
index 1545c858693fe769ddd6ef7d8b5ce948efacadbd..867bc8dc0e8b9e8a65fb46b053d84be0af70de78 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.h
@@ -201,6 +201,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
// TransferRegularFile.
//
// Must be called from *UI* thread. |callback| is run on the calling thread.
+ // |callback| must not be null.
void TransferFileForResourceId(const FilePath& local_file_path,
const FilePath& remote_dest_file_path,
const FileOperationCallback& callback,
@@ -321,6 +322,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
// |local_dest_file_path|.
//
// Can be called from UI thread. |callback| is run on the calling thread.
+ // |callback| must not be null.
void OnGetFileCompleteForTransferFile(const FilePath& local_dest_file_path,
const FileOperationCallback& callback,
GDataFileError error,
@@ -346,6 +348,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
// and names the copied document as |new_name|.
//
// Can be called from UI thread. |callback| is run on the calling thread.
+ // |callback| must not be null.
void CopyDocumentToDirectory(const FilePath& dir_path,
const std::string& resource_id,
const FilePath::StringType& new_name,
@@ -412,6 +415,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
const FilePath& cache_file_path);
// Callback for handling document copy attempt.
+ // |callback| must not be null.
void OnCopyDocumentCompleted(const FilePath& dir_path,
const FileOperationCallback& callback,
GDataErrorCode status,
@@ -741,7 +745,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
const base::Closure& callback);
// Part of CopyOnUIThread(). Called after GetEntryInfoPairByPaths() is
- // complete.
+ // complete. |callback| must not be null.
void CopyOnUIThreadAfterGetEntryInfoPair(
const FilePath& dest_file_path,
const FileOperationCallback& callback,
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_file_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698