Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Side by Side Diff: chrome/browser/chromeos/gdata/gdata_file_system_interface.h

Issue 10824240: gdata: Make callback parameters mandatory for TransferFile functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_
6 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_ 6 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // Can be called from UI/IO thread. |callback| is run on the calling thread. 139 // Can be called from UI/IO thread. |callback| is run on the calling thread.
140 virtual void GetEntryInfoByResourceId( 140 virtual void GetEntryInfoByResourceId(
141 const std::string& resource_id, 141 const std::string& resource_id,
142 const GetEntryInfoWithFilePathCallback& callback) = 0; 142 const GetEntryInfoWithFilePathCallback& callback) = 0;
143 143
144 // Initiates transfer of |remote_src_file_path| to |local_dest_file_path|. 144 // Initiates transfer of |remote_src_file_path| to |local_dest_file_path|.
145 // |remote_src_file_path| is the virtual source path on the gdata file system. 145 // |remote_src_file_path| is the virtual source path on the gdata file system.
146 // |local_dest_file_path| is the destination path on the local file system. 146 // |local_dest_file_path| is the destination path on the local file system.
147 // 147 //
148 // Must be called from *UI* thread. |callback| is run on the calling thread. 148 // Must be called from *UI* thread. |callback| is run on the calling thread.
149 // |callback| must not be null.
149 virtual void TransferFileFromRemoteToLocal( 150 virtual void TransferFileFromRemoteToLocal(
150 const FilePath& remote_src_file_path, 151 const FilePath& remote_src_file_path,
151 const FilePath& local_dest_file_path, 152 const FilePath& local_dest_file_path,
152 const FileOperationCallback& callback) = 0; 153 const FileOperationCallback& callback) = 0;
153 154
154 // Initiates transfer of |local_src_file_path| to |remote_dest_file_path|. 155 // Initiates transfer of |local_src_file_path| to |remote_dest_file_path|.
155 // |local_src_file_path| must be a file from the local file system. 156 // |local_src_file_path| must be a file from the local file system.
156 // |remote_dest_file_path| is the virtual destination path within gdata file 157 // |remote_dest_file_path| is the virtual destination path within gdata file
157 // system. 158 // system.
158 // 159 //
159 // Must be called from *UI* thread. |callback| is run on the calling thread. 160 // Must be called from *UI* thread. |callback| is run on the calling thread.
161 // |callback| must not be null.
160 virtual void TransferFileFromLocalToRemote( 162 virtual void TransferFileFromLocalToRemote(
161 const FilePath& local_src_file_path, 163 const FilePath& local_src_file_path,
162 const FilePath& remote_dest_file_path, 164 const FilePath& remote_dest_file_path,
163 const FileOperationCallback& callback) = 0; 165 const FileOperationCallback& callback) = 0;
164 166
165 // Retrieves a file at the virtual path |file_path| on the gdata file system 167 // Retrieves a file at the virtual path |file_path| on the gdata file system
166 // onto the cache, and mark it dirty. The local path to the cache file is 168 // onto the cache, and mark it dirty. The local path to the cache file is
167 // returned to |callback|. After opening the file, both read and write 169 // returned to |callback|. After opening the file, both read and write
168 // on the file can be done with normal local file operations. 170 // on the file can be done with normal local file operations.
169 // 171 //
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 const FilePath& virtual_dir_path, 354 const FilePath& virtual_dir_path,
353 scoped_ptr<DocumentEntry> entry, 355 scoped_ptr<DocumentEntry> entry,
354 const FilePath& file_content_path, 356 const FilePath& file_content_path,
355 GDataCache::FileOperationType cache_operation, 357 GDataCache::FileOperationType cache_operation,
356 const base::Closure& callback) = 0; 358 const base::Closure& callback) = 0;
357 }; 359 };
358 360
359 } // namespace gdata 361 } // namespace gdata
360 362
361 #endif // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_ 363 #endif // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698