[6] Moves CreateVersionFromString to plugin_utils and updates the callers.

chrome/browser/plugin_finder.h

Index: chrome/browser/plugin_finder.h
diff --git a/chrome/browser/plugin_finder.h b/chrome/browser/plugin_finder.h
index f0d75d5c10acbe6612852b7b1fd304e0e8923496..94e57b26982292b29c5aad3fd66ce106ba440413 100644
--- a/chrome/browser/plugin_finder.h
+++ b/chrome/browser/plugin_finder.h
@@ -34,9 +34,16 @@ class PluginFinder {
   // Returns the plug-in with the given identifier.
   PluginInstaller* FindPluginWithIdentifier(const std::string& identifier);
 
+  // Returns  a map of all data loaded from:

[Bernhard Bauer, 2012/08/21 12:30:18]

Nit: one space too many.

[ibraaaa, 2012/08/21 14:26:04]

Done.

+  // 'chrome/browser/resources/plugin_metadata/plugins_*.json' files.

[Bernhard Bauer, 2012/08/21 12:30:18]

I think we can just refer to the plugin metadata files here. Otherwise the
comment will inevitably become stale at some point ;-)

[ibraaaa, 2012/08/21 14:26:04]

Done.

+  // The key is the plug-in identifier.
+  // The value is an instance of PluginInstaller holding the loaded data.
+  const std::map<std::string, PluginInstaller*>& GetAllPluginInstallers();
+
  private:
   friend struct DefaultSingletonTraits<PluginFinder>;
   friend class Singleton<PluginFinder>;
+  friend class PluginInstaller;

[Bernhard Bauer, 2012/08/21 12:30:18]

Nit: Move before Singleton to keep this alphabetized.

[ibraaaa, 2012/08/21 14:26:04]

Done.

   FRIEND_TEST_ALL_PREFIXES(PluginFinderTest, JsonSyntax);
   FRIEND_TEST_ALL_PREFIXES(PluginFinderTest, PluginGroups);