[6] Moves CreateVersionFromString to plugin_utils and updates the callers.

chrome/browser/plugin_finder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PLUGIN_FINDER_H_
 #define CHROME_BROWSER_PLUGIN_FINDER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 16 matching lines @@
 
   // Finds a plug-in for the given MIME type and language (specified as an IETF
   // language tag, i.e. en-US) and returns the PluginInstaller for the plug-in,
   // or NULL if no plug-in is found.
   PluginInstaller* FindPlugin(const std::string& mime_type,
                               const std::string& language);
 
   // Returns the plug-in with the given identifier.
   PluginInstaller* FindPluginWithIdentifier(const std::string& identifier);
 
+  // Returns  a map of all data loaded from:

[Bernhard Bauer, 2012/08/21 12:30:18]

Nit: one space too many.

[ibraaaa, 2012/08/21 14:26:04]

Done.

+  // 'chrome/browser/resources/plugin_metadata/plugins_*.json' files.

[Bernhard Bauer, 2012/08/21 12:30:18]

I think we can just refer to the plugin metadata files here. Otherwise the
comment will inevitably become stale at some point ;-)

[ibraaaa, 2012/08/21 14:26:04]

Done.

+  // The key is the plug-in identifier.
+  // The value is an instance of PluginInstaller holding the loaded data.
+  const std::map<std::string, PluginInstaller*>& GetAllPluginInstallers();
+
  private:
   friend struct DefaultSingletonTraits<PluginFinder>;
   friend class Singleton<PluginFinder>;
+  friend class PluginInstaller;

[Bernhard Bauer, 2012/08/21 12:30:18]

Nit: Move before Singleton to keep this alphabetized.

[ibraaaa, 2012/08/21 14:26:04]

Done.

   FRIEND_TEST_ALL_PREFIXES(PluginFinderTest, JsonSyntax);
   FRIEND_TEST_ALL_PREFIXES(PluginFinderTest, PluginGroups);
 
   static PluginFinder* GetInstance();
 
   PluginFinder();
   ~PluginFinder();
 
   // Loads the plug-in information from the browser resources and parses it.
   // Returns NULL if the plug-in list couldn't be parsed.
   static base::DictionaryValue* LoadPluginList();
 
   PluginInstaller* CreateInstaller(const std::string& identifier,
                                    const base::DictionaryValue* plugin_dict);
 
   scoped_ptr<base::DictionaryValue> plugin_list_;
   std::map<std::string, PluginInstaller*> installers_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginFinder);
 };
 
 #endif  // CHROME_BROWSER_PLUGIN_FINDER_H_