[6] Moves CreateVersionFromString to plugin_utils and updates the callers.

chrome/browser/plugin_finder.cc

Index: chrome/browser/plugin_finder.cc
diff --git a/chrome/browser/plugin_finder.cc b/chrome/browser/plugin_finder.cc
index 59a5052950cf60ac6ac7d8b85a1689af4106de23..12107776b55966966ffaa91371c343f24e798092 100644
--- a/chrome/browser/plugin_finder.cc
+++ b/chrome/browser/plugin_finder.cc
@@ -8,6 +8,7 @@
 #include "base/json/json_reader.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
+#include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/plugin_installer.h"
@@ -129,12 +130,15 @@ PluginInstaller* PluginFinder::CreateInstaller(
   DCHECK(success);
   bool display_url = false;
   plugin_dict->GetBoolean("displayurl", &display_url);
-
+  string16 group_name_matcher;
+  success = plugin_dict->GetString("group_name_matcher", &group_name_matcher);
+  DCHECK(success);
   PluginInstaller* installer = new PluginInstaller(identifier,
                                                    name,
                                                    display_url,
                                                    GURL(url),
-                                                   GURL(help_url));
+                                                   GURL(help_url),
+                                                   group_name_matcher);
   const ListValue* versions = NULL;
   if (plugin_dict->GetList("versions", &versions)) {
     for (ListValue::const_iterator it = versions->begin();
@@ -161,3 +165,13 @@ PluginInstaller* PluginFinder::CreateInstaller(
   installers_[identifier] = installer;
   return installer;
 }
+
+const std::map<std::string, PluginInstaller*>& PluginFinder::

[Bernhard Bauer, 2012/08/21 12:30:18]

Ugh. I would either break this line after the return type (with the next line
not indented), or just extract the return type to a typedef.

[ibraaaa, 2012/08/21 14:26:04]

Done.

+    GetAllPluginInstallers() {
+  for (DictionaryValue::Iterator plugin_it(*plugin_list_);
+      plugin_it.HasNext(); plugin_it.Advance()) {
+    FindPluginWithIdentifier(plugin_it.key());

[Bernhard Bauer, 2012/08/21 12:30:18]

Can you add a comment that this triggers the lazy initialization of all the
PluginInstallers?

[ibraaaa, 2012/08/21 14:26:04]

Done.

+  }
+
+  return installers_;
+}