Implements part of DeviceMotion in the browser

Implements part of DeviceMotion in the browser

This adds the motion message filter, motion ipc messages, and related motion
files. This was originally part of a larger patch
(http://codereview.chromium.org/10698046/).


BUG=59201
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151908

[hans, 2012-08-14 10:41:31]

LGTM, just a nit about that switch statement

https://chromiumcodereview.appspot.com/10823310/diff/1/content/browser/device...
File content/browser/device_orientation/observer_delegate.cc (right):

https://chromiumcodereview.appspot.com/10823310/diff/1/content/browser/device...
content/browser/device_orientation/observer_delegate.cc:44: default:
i was hoping we would need to have a default case here, but just cover all the
cases explicitly.

I guess the only type that isn't covered is kTypeTest.. so maybe instead of the
default label, something like

case DeviceData::kTypeTest:
  NOTREACHED();

[aousterh, 2012-08-14 11:15:30]

https://chromiumcodereview.appspot.com/10823310/diff/1/content/browser/device...
File content/browser/device_orientation/observer_delegate.cc (right):

https://chromiumcodereview.appspot.com/10823310/diff/1/content/browser/device...
content/browser/device_orientation/observer_delegate.cc:44: default:
On 2012/08/14 10:41:31, hans wrote:
> i was hoping we would need to have a default case here, but just cover all the
> cases explicitly.
> 
> I guess the only type that isn't covered is kTypeTest.. so maybe instead of
the
> default label, something like
> 
> case DeviceData::kTypeTest:
>   NOTREACHED();

It still has to return NULL, but we can avoid having the default case. Done.

[aousterh, 2012-08-14 11:24:43]

jam: can you do an owners review for ipc/ and content/? Thanks!

[jam, 2012-08-14 15:28:27]

http://codereview.chromium.org/10823310/diff/16/content/browser/device_orient...
File content/browser/device_orientation/device_data.h (right):

http://codereview.chromium.org/10823310/diff/16/content/browser/device_orient...
content/browser/device_orientation/device_data.h:15: namespace
device_orientation {
code in content should be in the content namespace, not any other namespace. you
can fix this file in a followup change, but all the new files that you're adding
should be in "content" namespace

[hans, 2012-08-15 11:29:21]

Just realized we should probably have BUG=59201 in the description.

[aousterh, 2012-08-15 18:37:51]

Thanks!

I moved the rest of the device_orientation files to the content namespace in a
separate patch (https://chromiumcodereview.appspot.com/10823318) and updated
this patch so that the new files are in content as well.

I also rebased, so there are a few changes from that.

[jam, 2012-08-15 19:13:45]

lgtm, thanks

http://codereview.chromium.org/10823310/diff/8001/content/browser/device_orie...
File content/browser/device_orientation/motion_message_filter.cc (right):

http://codereview.chromium.org/10823310/diff/8001/content/browser/device_orie...
content/browser/device_orientation/motion_message_filter.cc:11: using
content::BrowserThread;
nit: not needed

[aousterh, 2012-08-16 13:09:14]

Thanks! I made that small change and rebased.

http://codereview.chromium.org/10823310/diff/8001/content/browser/device_orie...
File content/browser/device_orientation/motion_message_filter.cc (right):

http://codereview.chromium.org/10823310/diff/8001/content/browser/device_orie...
content/browser/device_orientation/motion_message_filter.cc:11: using
content::BrowserThread;
On 2012/08/15 19:13:45, John Abd-El-Malek wrote:
> nit: not needed

Done.

[commit-bot: I haz the power, 2012-08-16 13:09:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aousterh@chromium.org/10823310/19

[commit-bot: I haz the power, 2012-08-16 13:22:09]

Try job failure for 10823310-19 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-08-16 13:41:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aousterh@chromium.org/10823310/10007

[commit-bot: I haz the power, 2012-08-16 14:37:06]

Try job failure for 10823310-10007 (retry) on linux_rel for step
"interactive_ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-16 14:42:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aousterh@chromium.org/10823310/10007

[commit-bot: I haz the power, 2012-08-16 17:07:33]

Change committed as 151908