Issue 10823318: Moves device_orientation to content namespace

Issue 10823318: Moves device_orientation to content namespace (Closed)

Created:
8 years, 4 months ago by aousterh

Modified:
8 years, 4 months ago

Reviewers:
hans, Satish, jam, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Moves device_orientation to content namespace Code in content/ should be in the content namespace. TBR=jam BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151684

Patch Set 2 : Attempts to fix trybots #

Total comments: 6

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -44 lines)			Patch
M	base/android/jni_generator/jni_generator_tests.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/device_orientation/accelerometer_mac.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/accelerometer_mac.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/data_fetcher.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/data_fetcher_impl_android.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/data_fetcher_impl_android.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/device_data.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/device_orientation_browsertest.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/browser/device_orientation/message_filter.h	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/browser/device_orientation/message_filter.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/browser/device_orientation/observer_delegate.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/observer_delegate.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/orientation.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/orientation.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/orientation_message_filter.h	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/browser/device_orientation/orientation_message_filter.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/browser/device_orientation/provider.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/provider.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/browser/device_orientation/provider_impl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/provider_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/device_orientation/provider_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/device_orientation_messages.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/DeviceOrientation.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aousterh@chromium.org/10823318/1

8 years, 4 months ago (2012-08-14 18:17:30 UTC) #5

commit-bot: I haz the power

Try job failure for 10823318-1 (retry) on android for steps "compile, build" (clobber build). It's ...

8 years, 4 months ago (2012-08-14 18:35:48 UTC) #6

hans

On 2012/08/14 18:35:48, I haz the power (commit-bot) wrote: > Try job failure for 10823318-1 ...

8 years, 4 months ago (2012-08-15 07:28:00 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aousterh@chromium.org/10823318/5002

8 years, 4 months ago (2012-08-15 08:58:43 UTC) #8

commit-bot: I haz the power

Presubmit check for 10823318-5002 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 4 months ago (2012-08-15 08:58:53 UTC) #9

aousterh

satish: can you do an owners review for content/public/android and base/android?

8 years, 4 months ago (2012-08-15 09:02:34 UTC) #10

aousterh

satish: can you do an owners review for content/public/android and base/android?

8 years, 4 months ago (2012-08-15 09:03:05 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aousterh@chromium.org/10823318/5002

8 years, 4 months ago (2012-08-15 09:11:19 UTC) #13

jam

thanks! https://chromiumcodereview.appspot.com/10823318/diff/5002/content/browser/device_orientation/device_orientation_browsertest.cc File content/browser/device_orientation/device_orientation_browsertest.cc (right): https://chromiumcodereview.appspot.com/10823318/diff/5002/content/browser/device_orientation/device_orientation_browsertest.cc#newcode46 content/browser/device_orientation/device_orientation_browsertest.cc:46: class DeviceOrientationBrowserTest : public content::ContentBrowserTest { nit: get ...

8 years, 4 months ago (2012-08-15 19:12:46 UTC) #15

aousterh

8 years, 4 months ago (2012-08-16 14:39:35 UTC) #16

Thanks for the feedback! Please see
https://chromiumcodereview.appspot.com/10854185/ for the small changes you
suggested.

Expand Messages | Collapse Messages