Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10823267: NaCl VS Addin Crash Fix (Closed)

Created:
8 years, 4 months ago by tysand
Modified:
8 years, 4 months ago
Reviewers:
noelallen1
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl VS Addin Crash Fix Fixed a crash caused by main Chrome process shutting down, and removed PlatformToolset property from NaCl platform. BUG=136414 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerBase.cs View 3 chunks +22 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs View 1 chunk +1 line, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs View 1 chunk +4 lines, -4 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PluginDebuggerGDBTest.cs View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tysand
8 years, 4 months ago (2012-08-09 21:52:58 UTC) #1
noelallen1
8 years, 4 months ago (2012-08-09 21:59:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698