visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs - Issue 10823267: NaCl VS Addin Crash Fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

Issue 10823267: NaCl VS Addin Crash Fix (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerBase.cs ('k') | visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

diff --git a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

index 2dbf6bbfabc4c9d270202018413cdd2aec6b8217..f4cebfe179bd270e6cd4bec86e72f39459e4cbc8 100644

--- a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

+++ b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

@@ -67,7 +67,7 @@ namespace NativeClientVSAddIn

gdbPath_ = Path.Combine(

properties.SDKRootDirectory,

"toolchain",

- properties.PlatformToolset,

+ string.Concat("win_x86_", properties.ToolchainName),

@"bin\x86_64-nacl-gdb.exe");

PluginFoundEvent += new EventHandler<PluginFoundEventArgs>(Attach);