Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

Issue 10823267: NaCl VS Addin Crash Fix (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 namespace NativeClientVSAddIn 5 namespace NativeClientVSAddIn
6 { 6 {
7 using System; 7 using System;
8 using System.IO; 8 using System.IO;
9 using System.Text; 9 using System.Text;
10 using System.Windows.Forms; 10 using System.Windows.Forms;
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 public PluginDebuggerGDB(DTE2 dte, PropertyManager properties) 60 public PluginDebuggerGDB(DTE2 dte, PropertyManager properties)
61 : base(dte, properties) 61 : base(dte, properties)
62 { 62 {
63 irtPath_ = properties.IrtPath; 63 irtPath_ = properties.IrtPath;
64 manifestPath_ = properties.ManifestPath; 64 manifestPath_ = properties.ManifestPath;
65 pluginAssembly_ = properties.PluginAssembly; 65 pluginAssembly_ = properties.PluginAssembly;
66 pluginProjectDirectory_ = properties.ProjectDirectory; 66 pluginProjectDirectory_ = properties.ProjectDirectory;
67 gdbPath_ = Path.Combine( 67 gdbPath_ = Path.Combine(
68 properties.SDKRootDirectory, 68 properties.SDKRootDirectory,
69 "toolchain", 69 "toolchain",
70 properties.PlatformToolset, 70 string.Concat("win_x86_", properties.ToolchainName),
71 @"bin\x86_64-nacl-gdb.exe"); 71 @"bin\x86_64-nacl-gdb.exe");
72 72
73 PluginFoundEvent += new EventHandler<PluginFoundEventArgs>(Attach); 73 PluginFoundEvent += new EventHandler<PluginFoundEventArgs>(Attach);
74 } 74 }
75 75
76 /// <summary> 76 /// <summary>
77 /// Disposes the object. If disposing is false then this has been called by garbage collection, 77 /// Disposes the object. If disposing is false then this has been called by garbage collection,
78 /// and we shouldn't reference managed objects. 78 /// and we shouldn't reference managed objects.
79 /// </summary> 79 /// </summary>
80 /// <param name="disposing">True if user call to Dispose, false if garbage c ollection.</param> 80 /// <param name="disposing">True if user call to Dispose, false if garbage c ollection.</param>
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 gdbProcess_.Start(); 207 gdbProcess_.Start();
208 } 208 }
209 catch (Exception e) 209 catch (Exception e)
210 { 210 {
211 MessageBox.Show( 211 MessageBox.Show(
212 string.Format("NaCl-GDB Start Failed. {0}. Path: {1}", e.Message, gd bPath_)); 212 string.Format("NaCl-GDB Start Failed. {0}. Path: {1}", e.Message, gd bPath_));
213 } 213 }
214 } 214 }
215 } 215 }
216 } 216 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698