Issue 10823029: Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_b…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823029: Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_b… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, dhollowa+watch_chromium.org, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, dyu1, tfarina, ajwong+watch_chromium.org, Ilya Sherman, browser-components-watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_browsertests. BUG=90448 TBR=viettrungluu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148463

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -48 lines)			Patch
M	chrome/browser/autofill/autofill_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_focus_uitest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/web_request/web_request_apitest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/referrer_policy_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_browser_tests.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_browsertest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_close_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/pdf/pdf_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/test/perf/rendering/throughput_tests.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_manager_browsertest.cc	View	12 chunks	+12 lines, -12 lines	0 comments	Download
M	content/public/test/browser_test_utils.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/test/browser_test_utils.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

8 years, 4 months ago (2012-07-28 06:49:36 UTC) #2

I'm totally mystified why I was the one TBRed, but rubberstamp LGTM anyway.

Expand Messages | Collapse Messages