Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 10823029: Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_b… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h" 9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_tabstrip.h" 11 #include "chrome/browser/ui/browser_tabstrip.h"
12 #include "chrome/browser/ui/views/ssl_client_certificate_selector.h" 12 #include "chrome/browser/ui/views/ssl_client_certificate_selector.h"
13 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
14 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
15 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
16 #include "content/public/test/browser_test_utils.h"
16 #include "net/base/cert_test_util.h" 17 #include "net/base/cert_test_util.h"
17 #include "net/base/ssl_cert_request_info.h" 18 #include "net/base/ssl_cert_request_info.h"
18 #include "net/base/x509_certificate.h" 19 #include "net/base/x509_certificate.h"
19 #include "net/http/http_transaction_factory.h" 20 #include "net/http/http_transaction_factory.h"
20 #include "net/url_request/url_request.h" 21 #include "net/url_request/url_request.h"
21 #include "net/url_request/url_request_context.h" 22 #include "net/url_request/url_request_context.h"
22 #include "net/url_request/url_request_context_getter.h" 23 #include "net/url_request/url_request_context_getter.h"
23 #include "testing/gtest/include/gtest/gtest.h" 24 #include "testing/gtest/include/gtest/gtest.h"
24 25
25 using ::testing::Mock; 26 using ::testing::Mock;
(...skipping 28 matching lines...) Expand all
54 55
55 virtual void SetUpOnMainThread() { 56 virtual void SetUpOnMainThread() {
56 url_request_context_getter_ = browser()->profile()->GetRequestContext(); 57 url_request_context_getter_ = browser()->profile()->GetRequestContext();
57 58
58 BrowserThread::PostTask( 59 BrowserThread::PostTask(
59 BrowserThread::IO, FROM_HERE, 60 BrowserThread::IO, FROM_HERE,
60 base::Bind(&SSLClientCertificateSelectorTest::SetUpOnIOThread, this)); 61 base::Bind(&SSLClientCertificateSelectorTest::SetUpOnIOThread, this));
61 62
62 io_loop_finished_event_.Wait(); 63 io_loop_finished_event_.Wait();
63 64
64 ui_test_utils::WaitForLoadStop(chrome::GetActiveWebContents(browser())); 65 content::WaitForLoadStop(chrome::GetActiveWebContents(browser()));
65 selector_ = new SSLClientCertificateSelector( 66 selector_ = new SSLClientCertificateSelector(
66 chrome::GetActiveTabContents(browser()), 67 chrome::GetActiveTabContents(browser()),
67 auth_requestor_->http_network_session_, 68 auth_requestor_->http_network_session_,
68 auth_requestor_->cert_request_info_, 69 auth_requestor_->cert_request_info_,
69 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 70 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
70 auth_requestor_)); 71 auth_requestor_));
71 selector_->Init(); 72 selector_->Init();
72 73
73 EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert()); 74 EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert());
74 } 75 }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 144
144 virtual void SetUpOnMainThread() { 145 virtual void SetUpOnMainThread() {
145 // Also calls SetUpOnIOThread. 146 // Also calls SetUpOnIOThread.
146 SSLClientCertificateSelectorTest::SetUpOnMainThread(); 147 SSLClientCertificateSelectorTest::SetUpOnMainThread();
147 148
148 AddTabAtIndex(1, GURL("about:blank"), content::PAGE_TRANSITION_LINK); 149 AddTabAtIndex(1, GURL("about:blank"), content::PAGE_TRANSITION_LINK);
149 AddTabAtIndex(2, GURL("about:blank"), content::PAGE_TRANSITION_LINK); 150 AddTabAtIndex(2, GURL("about:blank"), content::PAGE_TRANSITION_LINK);
150 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 0)); 151 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 0));
151 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 1)); 152 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 1));
152 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 2)); 153 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 2));
153 ui_test_utils::WaitForLoadStop(chrome::GetWebContentsAt(browser(), 1)); 154 content::WaitForLoadStop(chrome::GetWebContentsAt(browser(), 1));
154 ui_test_utils::WaitForLoadStop(chrome::GetWebContentsAt(browser(), 2)); 155 content::WaitForLoadStop(chrome::GetWebContentsAt(browser(), 2));
155 156
156 selector_1_ = new SSLClientCertificateSelector( 157 selector_1_ = new SSLClientCertificateSelector(
157 chrome::GetTabContentsAt(browser(), 1), 158 chrome::GetTabContentsAt(browser(), 1),
158 auth_requestor_1_->http_network_session_, 159 auth_requestor_1_->http_network_session_,
159 auth_requestor_1_->cert_request_info_, 160 auth_requestor_1_->cert_request_info_,
160 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 161 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
161 auth_requestor_1_)); 162 auth_requestor_1_));
162 selector_1_->Init(); 163 selector_1_->Init();
163 selector_2_ = new SSLClientCertificateSelector( 164 selector_2_ = new SSLClientCertificateSelector(
164 chrome::GetTabContentsAt(browser(), 2), 165 chrome::GetTabContentsAt(browser(), 2),
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 EXPECT_TRUE(ui_test_utils::SendKeyPressSync( 370 EXPECT_TRUE(ui_test_utils::SendKeyPressSync(
370 browser_1_, ui::VKEY_RETURN, false, false, false, false)); 371 browser_1_, ui::VKEY_RETURN, false, false, false, false));
371 372
372 Mock::VerifyAndClear(auth_requestor_.get()); 373 Mock::VerifyAndClear(auth_requestor_.get());
373 Mock::VerifyAndClear(auth_requestor_1_.get()); 374 Mock::VerifyAndClear(auth_requestor_1_.get());
374 375
375 // Now let the default selection for auth_requestor_ mock get checked on 376 // Now let the default selection for auth_requestor_ mock get checked on
376 // destruction. 377 // destruction.
377 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL)); 378 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL));
378 } 379 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698