Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/browser_close_browsertest.cc

Issue 10823029: Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_b… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/download/download_service.h" 10 #include "chrome/browser/download/download_service.h"
11 #include "chrome/browser/download/download_service_factory.h" 11 #include "chrome/browser/download/download_service_factory.h"
12 #include "chrome/browser/download/download_test_observer.h" 12 #include "chrome/browser/download/download_test_observer.h"
13 #include "chrome/browser/net/url_request_mock_util.h" 13 #include "chrome/browser/net/url_request_mock_util.h"
14 #include "chrome/browser/prefs/pref_service.h" 14 #include "chrome/browser/prefs/pref_service.h"
15 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/profiles/profile_manager.h" 16 #include "chrome/browser/profiles/profile_manager.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/browser_list.h" 18 #include "chrome/browser/ui/browser_list.h"
19 #include "chrome/browser/ui/browser_tabstrip.h" 19 #include "chrome/browser/ui/browser_tabstrip.h"
20 #include "chrome/browser/ui/browser_window.h" 20 #include "chrome/browser/ui/browser_window.h"
21 #include "chrome/common/chrome_paths.h" 21 #include "chrome/common/chrome_paths.h"
22 #include "chrome/common/pref_names.h" 22 #include "chrome/common/pref_names.h"
23 #include "chrome/common/url_constants.h" 23 #include "chrome/common/url_constants.h"
24 #include "chrome/test/base/in_process_browser_test.h" 24 #include "chrome/test/base/in_process_browser_test.h"
25 #include "chrome/test/base/ui_test_utils.h" 25 #include "chrome/test/base/ui_test_utils.h"
26 #include "content/public/browser/download_item.h" 26 #include "content/public/browser/download_item.h"
27 #include "content/public/common/page_transition_types.h" 27 #include "content/public/common/page_transition_types.h"
28 #include "content/public/test/browser_test_utils.h"
28 #include "content/test/net/url_request_slow_download_job.h" 29 #include "content/test/net/url_request_slow_download_job.h"
29 30
30 using content::BrowserContext; 31 using content::BrowserContext;
31 using content::BrowserThread; 32 using content::BrowserThread;
32 using content::DownloadItem; 33 using content::DownloadItem;
33 using content::DownloadManager; 34 using content::DownloadManager;
34 35
35 class BrowserCloseTest : public InProcessBrowserTest { 36 class BrowserCloseTest : public InProcessBrowserTest {
36 public: 37 public:
37 // Structure defining test cases for DownloadsCloseCheck. 38 // Structure defining test cases for DownloadsCloseCheck.
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 } 168 }
168 } 169 }
169 } 170 }
170 } 171 }
171 172
172 // Create a Browser (with associated window) on the specified profile. 173 // Create a Browser (with associated window) on the specified profile.
173 Browser* CreateBrowserOnProfile(Profile* profile) { 174 Browser* CreateBrowserOnProfile(Profile* profile) {
174 Browser* new_browser = new Browser(Browser::CreateParams(profile)); 175 Browser* new_browser = new Browser(Browser::CreateParams(profile));
175 chrome::AddSelectedTabWithURL(new_browser, GURL(chrome::kAboutBlankURL), 176 chrome::AddSelectedTabWithURL(new_browser, GURL(chrome::kAboutBlankURL),
176 content::PAGE_TRANSITION_START_PAGE); 177 content::PAGE_TRANSITION_START_PAGE);
177 ui_test_utils::WaitForLoadStop( 178 content::WaitForLoadStop(chrome::GetActiveWebContents(new_browser));
178 chrome::GetActiveWebContents(new_browser));
179 new_browser->window()->Show(); 179 new_browser->window()->Show();
180 return new_browser; 180 return new_browser;
181 } 181 }
182 182
183 // Adjust the number of browsers and associated windows up or down 183 // Adjust the number of browsers and associated windows up or down
184 // to |num_windows|. This routine assumes that there is only a single 184 // to |num_windows|. This routine assumes that there is only a single
185 // browser associated with the profile on entry. |*base_browser| contains 185 // browser associated with the profile on entry. |*base_browser| contains
186 // this browser, and the profile is derived from that browser. On output, 186 // this browser, and the profile is derived from that browser. On output,
187 // if |*base_browser| was destroyed (because |num_windows == 0|), NULL 187 // if |*base_browser| was destroyed (because |num_windows == 0|), NULL
188 // is assigned to that memory location. 188 // is assigned to that memory location.
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 } 569 }
570 } 570 }
571 571
572 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, MAYBE_DownloadsCloseCheck_5) { 572 IN_PROC_BROWSER_TEST_F(BrowserCloseTest, MAYBE_DownloadsCloseCheck_5) {
573 ASSERT_TRUE(SetupForDownloadCloseCheck()); 573 ASSERT_TRUE(SetupForDownloadCloseCheck());
574 for (size_t i = 5 * arraysize(download_close_check_cases) / 6; 574 for (size_t i = 5 * arraysize(download_close_check_cases) / 6;
575 i < 6 * arraysize(download_close_check_cases) / 6; ++i) { 575 i < 6 * arraysize(download_close_check_cases) / 6; ++i) {
576 ExecuteDownloadCloseCheckCase(i); 576 ExecuteDownloadCloseCheckCase(i);
577 } 577 }
578 } 578 }
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu_browsertest.cc ('k') | chrome/browser/ui/pdf/pdf_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698