Handle no volume in chrome://media-internals

Handle no volume in chrome://media-internals

When using Pepper Flash chrome://media-internals displays NaN for volume.

Volume may never be set by plugins like Pepper Flash. Fix is to only display volume information if it exists.

(Also fixed presubmit errors.)

BUG=64215
TEST=Ran on youtube and verified that volume wasn't displayed. Ran on music.google.com and verified that volume was displayed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149228

[tommi (sloooow) - chröme, 2012-07-31 10:06:01]

lgtm

[commit-bot: I haz the power, 2012-07-31 14:14:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10821058/1

[commit-bot: I haz the power, 2012-07-31 14:14:11]

Presubmit check for 10821058-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources

Presubmit checks took 1.0s to calculate.

[sail, 2012-07-31 14:18:50]

jhawkins: chrome/browser/resources/ OWNERS review

[James Hawkins, 2012-07-31 16:49:07]

LGTM with question.

http://codereview.chromium.org/10821058/diff/1/chrome/browser/resources/media...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/10821058/diff/1/chrome/browser/resources/media...
chrome/browser/resources/media_internals.html:12: <script
src="chrome://resources/js/util.js"></script>
util.js is already included in the src.  This should not be necessary, yeah?

[sail, 2012-07-31 16:51:51]

http://codereview.chromium.org/10821058/diff/1/chrome/browser/resources/media...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/10821058/diff/1/chrome/browser/resources/media...
chrome/browser/resources/media_internals.html:12: <script
src="chrome://resources/js/util.js"></script>
On 2012/07/31 16:49:07, James Hawkins wrote:
> util.js is already included in the src.  This should not be necessary, yeah?

ahh, that's actually including chrome/browser/resources/media_internals/util.js

[James Hawkins, 2012-07-31 16:52:34]

http://codereview.chromium.org/10821058/diff/1/chrome/browser/resources/media...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/10821058/diff/1/chrome/browser/resources/media...
chrome/browser/resources/media_internals.html:12: <script
src="chrome://resources/js/util.js"></script>
On 2012/07/31 16:51:51, sail wrote:
> On 2012/07/31 16:49:07, James Hawkins wrote:
> > util.js is already included in the src.  This should not be necessary, yeah?
> 
> ahh, that's actually including
chrome/browser/resources/media_internals/util.js

Gotcha, I should have read more carefully.  SLGTM

[commit-bot: I haz the power, 2012-07-31 16:54:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10821058/1

[commit-bot: I haz the power, 2012-07-31 18:16:42]

Change committed as 149228