Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/resources/media_internals/media_internals.js

Issue 10821058: Handle no volume in chrome://media-internals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_internals/media_internals.js
diff --git a/chrome/browser/resources/media_internals/media_internals.js b/chrome/browser/resources/media_internals/media_internals.js
index 7218c06b8d8596c554c6f6bdf9ee337043d65822..09821c81f048f3b04d5c222c25244d5ac164db2d 100644
--- a/chrome/browser/resources/media_internals/media_internals.js
+++ b/chrome/browser/resources/media_internals/media_internals.js
@@ -41,8 +41,8 @@ cr.define('media', function() {
* Initialize variables and ask MediaInternals for all its data.
*/
function initialize() {
- audioStreamDiv = document.getElementById('audio-streams');
- cacheDiv = document.getElementById('cache-entries');
+ audioStreamDiv = $('audio-streams');
+ cacheDiv = $('cache-entries');
// Get information about all currently active media.
chrome.send('getEverything');
@@ -66,14 +66,16 @@ cr.define('media', function() {
out.textContent += 'Audio stream ' + stream.id.split('.')[1];
out.textContent += ' is ' + (stream.playing ? 'playing' : 'paused');
- out.textContent += ' at ' + (stream.volume * 100).toFixed(0);
- out.textContent += '% volume.';
+ if (typeof stream.volume != 'undefined') {
+ out.textContent += ' at ' + (stream.volume * 100).toFixed(0);
+ out.textContent += '% volume.';
+ }
return out;
}
var out = document.createElement('ul');
audioStreams.map(printStream).forEach(function(s) {
- out.appendChild(s)
+ out.appendChild(s);
});
audioStreamDiv.textContent = '';
@@ -147,7 +149,7 @@ cr.define('media', function() {
function onRendererTerminated(renderer) {
for (var key in mediaPlayers) {
if (mediaPlayers[key].renderer == renderer) {
- document.getElementById('media-players').removeChild(mediaPlayers[key]);
+ $('media-players').removeChild(mediaPlayers[key]);
delete mediaPlayers[key];
break;
}

Powered by Google App Engine
This is Rietveld 408576698