Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10820034: Remove redirection header and add "ui::" before all SelectFileDialog usage. (Closed)

Created:
8 years, 5 months ago by Elliot Glaysher
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, rdsmith+dwatch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove redirection header and add "ui::" before all SelectFileDialog usage. BUG=134529 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149111

Patch Set 1 #

Patch Set 2 : Fix test compile #

Patch Set 3 : chromeos and win compile #

Patch Set 4 : More chromeos fix #

Patch Set 5 : More chromeos fix #

Patch Set 6 : Rebase ToT #

Patch Set 7 : Reuploading for different try run. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -224 lines) Patch
M chrome/browser/bookmarks/bookmark_extension_api.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_file_helper.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_file_picker.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_file_picker.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/save_package_file_picker_chromeos.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/save_package_file_picker_chromeos.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/file_select_helper.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 6 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/ui/browser.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/certificate_dialogs.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/certificate_dialogs.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/chrome_select_file_policy_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
D chrome/browser/ui/select_file_dialog.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 2 3 4 10 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog_view.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options2/media_galleries_handler.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/media_galleries_handler.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 9 chunks +18 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
This patch is really simple, though long. It removes a redirection header, and adds "ui::" ...
8 years, 4 months ago (2012-07-27 16:58:53 UTC) #1
jam
redirecting to Nico, another owner in chrome
8 years, 4 months ago (2012-07-27 23:40:29 UTC) #2
Nico
lgtm
8 years, 4 months ago (2012-07-27 23:46:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10820034/12136
8 years, 4 months ago (2012-07-30 21:48:41 UTC) #4
commit-bot: I haz the power
Try job failure for 10820034-12136 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-31 00:26:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10820034/12136
8 years, 4 months ago (2012-07-31 00:29:10 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 01:43:17 UTC) #7 
Change committed as 149111

Powered by Google App Engine
This is Rietveld 408576698