chrome/browser/ui/webui/extensions/pack_extension_handler.cc - Issue 10820034: Remove redirection header and add "ui::" before all SelectFileDialog usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

Issue 10820034: Remove redirection header and add "ui::" before all SelectFileDialog usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reuploading for different try run. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/pack_extension_handler.h ('k') | chrome/browser/ui/webui/options2/browser_options_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

index d4a8000f0abe4a7369455af31018076caa149a3a..9381cff629e76e1f524e792374542cdb1eaa2a86 100644

--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

@@ -157,11 +157,11 @@ void PackExtensionHandler::HandleSelectFilePathMessage(

if (!args->GetString(1, &operation))

NOTREACHED();

- SelectFileDialog::Type type = SelectFileDialog::SELECT_FOLDER;

- SelectFileDialog::FileTypeInfo info;

+ ui::SelectFileDialog::Type type = ui::SelectFileDialog::SELECT_FOLDER;

+ ui::SelectFileDialog::FileTypeInfo info;

int file_type_index = 0;

if (select_type == "file")

- type = SelectFileDialog::SELECT_OPEN_FILE;

+ type = ui::SelectFileDialog::SELECT_OPEN_FILE;

string16 select_title;

if (operation == "load") {

@@ -180,7 +180,7 @@ void PackExtensionHandler::HandleSelectFilePathMessage(

NOTREACHED();

}

- load_extension_dialog_ = SelectFileDialog::Create(

+ load_extension_dialog_ = ui::SelectFileDialog::Create(

this, new ChromeSelectFilePolicy(web_ui()->GetWebContents()));

load_extension_dialog_->SelectFile(

type, select_title, FilePath(), &info, file_type_index,