Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

Issue 10820034: Remove redirection header and add "ui::" before all SelectFileDialog usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reuploading for different try run. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/select_file_dialog_extension.h" 5 #include "chrome/browser/ui/views/select_file_dialog_extension.h"
6 6
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "ui/base/dialogs/selected_file_info.h" 8 #include "ui/base/dialogs/selected_file_info.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 class SelectFileDialogExtensionTest : public testing::Test { 11 class SelectFileDialogExtensionTest : public testing::Test {
12 public: 12 public:
13 static SelectFileDialogExtension* CreateDialog( 13 static SelectFileDialogExtension* CreateDialog(
14 SelectFileDialog::Listener* listener, 14 ui::SelectFileDialog::Listener* listener,
15 int32 tab_id) { 15 int32 tab_id) {
16 SelectFileDialogExtension* dialog = new SelectFileDialogExtension(listener, 16 SelectFileDialogExtension* dialog = new SelectFileDialogExtension(listener,
17 NULL); 17 NULL);
18 // Simulate the dialog opening. 18 // Simulate the dialog opening.
19 EXPECT_FALSE(SelectFileDialogExtension::PendingExists(tab_id)); 19 EXPECT_FALSE(SelectFileDialogExtension::PendingExists(tab_id));
20 dialog->AddPending(tab_id); 20 dialog->AddPending(tab_id);
21 EXPECT_TRUE(SelectFileDialogExtension::PendingExists(tab_id)); 21 EXPECT_TRUE(SelectFileDialogExtension::PendingExists(tab_id));
22 return dialog; 22 return dialog;
23 } 23 }
24 }; 24 };
25 25
26 // Client of a FileManagerDialog that deletes itself whenever the dialog 26 // Client of a FileManagerDialog that deletes itself whenever the dialog
27 // is closed. 27 // is closed.
28 class SelfDeletingClient : public SelectFileDialog::Listener { 28 class SelfDeletingClient : public ui::SelectFileDialog::Listener {
29 public: 29 public:
30 explicit SelfDeletingClient(int32 tab_id) { 30 explicit SelfDeletingClient(int32 tab_id) {
31 dialog_ = SelectFileDialogExtensionTest::CreateDialog(this, tab_id); 31 dialog_ = SelectFileDialogExtensionTest::CreateDialog(this, tab_id);
32 } 32 }
33 33
34 virtual ~SelfDeletingClient() { 34 virtual ~SelfDeletingClient() {
35 if (dialog_.get()) 35 if (dialog_.get())
36 dialog_->ListenerDestroyed(); 36 dialog_->ListenerDestroyed();
37 } 37 }
38 38
39 SelectFileDialogExtension* dialog() const { return dialog_.get(); } 39 SelectFileDialogExtension* dialog() const { return dialog_.get(); }
40 40
41 // SelectFileDialog::Listener implementation 41 // ui::SelectFileDialog::Listener implementation
42 virtual void FileSelected(const FilePath& path, 42 virtual void FileSelected(const FilePath& path,
43 int index, void* params) OVERRIDE { 43 int index, void* params) OVERRIDE {
44 delete this; 44 delete this;
45 } 45 }
46 46
47 private: 47 private:
48 scoped_refptr<SelectFileDialogExtension> dialog_; 48 scoped_refptr<SelectFileDialogExtension> dialog_;
49 }; 49 };
50 50
51 TEST_F(SelectFileDialogExtensionTest, SelfDeleting) { 51 TEST_F(SelectFileDialogExtensionTest, SelfDeleting) {
52 const int32 kTabId = 123; 52 const int32 kTabId = 123;
53 SelfDeletingClient* client = new SelfDeletingClient(kTabId); 53 SelfDeletingClient* client = new SelfDeletingClient(kTabId);
54 // Ensure we don't crash or trip an Address Sanitizer warning about 54 // Ensure we don't crash or trip an Address Sanitizer warning about
55 // use-after-free. 55 // use-after-free.
56 ui::SelectedFileInfo file_info; 56 ui::SelectedFileInfo file_info;
57 SelectFileDialogExtension::OnFileSelected(kTabId, file_info, 0); 57 SelectFileDialogExtension::OnFileSelected(kTabId, file_info, 0);
58 // Simulate closing the dialog so the listener gets invoked. 58 // Simulate closing the dialog so the listener gets invoked.
59 client->dialog()->ExtensionDialogClosing(NULL); 59 client->dialog()->ExtensionDialogClosing(NULL);
60 } 60 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698