Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 10800052: More -Wunused-private-field cleanups. (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

More -Wunused-private-field cleanups. As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html the warning finds more bugs. Fix them. BUG=none TEST=none TBR=owners Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M chrome/browser/extensions/api/cookies/cookies_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/mac/mock_launchd.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/mac/mock_launchd.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/gcapi_mac/gcapi.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/dns/dns_config_service_posix_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/web_socket_server_socket_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 5 months ago (2012-07-20 07:38:19 UTC) #1
Mark Mentovai
LGTM Did this warning already catch private fields that were only ever assigned other constants?
8 years, 5 months ago (2012-07-20 12:30:31 UTC) #2
Nico
On 2012/07/20 12:30:31, Mark Mentovai wrote: > LGTM > > Did this warning already catch ...
8 years, 5 months ago (2012-07-20 14:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10800052/1
8 years, 5 months ago (2012-07-20 14:22:43 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 16:17:31 UTC) #5
Change committed as 147666

Powered by Google App Engine
This is Rietveld 408576698