Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

Issue 10800052: More -Wunused-private-field cleanups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/chrome_fraudulent_certificate_reporter.h" 5 #include "chrome/browser/net/chrome_fraudulent_certificate_reporter.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 // For the first version of the feature, sending reports is "fire and forget". 116 // For the first version of the feature, sending reports is "fire and forget".
117 // Therefore, we test only that the Reporter tried to send a request at all. 117 // Therefore, we test only that the Reporter tried to send a request at all.
118 // In the future, when we have more sophisticated (i.e., any) error handling 118 // In the future, when we have more sophisticated (i.e., any) error handling
119 // and re-tries, we will need more sopisticated tests as well. 119 // and re-tries, we will need more sopisticated tests as well.
120 // 120 //
121 // This class doesn't do anything now, but in near future versions it will. 121 // This class doesn't do anything now, but in near future versions it will.
122 class MockURLRequest : public net::URLRequest { 122 class MockURLRequest : public net::URLRequest {
123 public: 123 public:
124 MockURLRequest(net::URLRequestContext* context) 124 MockURLRequest(net::URLRequestContext* context)
125 : net::URLRequest(GURL(""), NULL, context), 125 : net::URLRequest(GURL(""), NULL, context) {
126 passed_(false) {
127 } 126 }
128 127
129 private: 128 private:
130 bool passed_;
131 }; 129 };
132 130
133 // A ChromeFraudulentCertificateReporter that uses a MockURLRequest, but is 131 // A ChromeFraudulentCertificateReporter that uses a MockURLRequest, but is
134 // otherwise normal: reports are constructed and sent in the usual way. 132 // otherwise normal: reports are constructed and sent in the usual way.
135 class MockReporter : public ChromeFraudulentCertificateReporter { 133 class MockReporter : public ChromeFraudulentCertificateReporter {
136 public: 134 public:
137 explicit MockReporter(net::URLRequestContext* request_context) 135 explicit MockReporter(net::URLRequestContext* request_context)
138 : ChromeFraudulentCertificateReporter(request_context) {} 136 : ChromeFraudulentCertificateReporter(request_context) {}
139 137
140 virtual net::URLRequest* CreateURLRequest( 138 virtual net::URLRequest* CreateURLRequest(
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 } 195 }
198 196
199 TEST(ChromeFraudulentCertificateReporterTest, ReportIsNotSent) { 197 TEST(ChromeFraudulentCertificateReporterTest, ReportIsNotSent) {
200 MessageLoop loop(MessageLoop::TYPE_IO); 198 MessageLoop loop(MessageLoop::TYPE_IO);
201 content::TestBrowserThread io_thread(BrowserThread::IO, &loop); 199 content::TestBrowserThread io_thread(BrowserThread::IO, &loop);
202 loop.PostTask(FROM_HERE, base::Bind(&DoReportIsNotSent)); 200 loop.PostTask(FROM_HERE, base::Bind(&DoReportIsNotSent));
203 loop.RunAllPending(); 201 loop.RunAllPending();
204 } 202 }
205 203
206 } // namespace chrome_browser_net 204 } // namespace chrome_browser_net
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698