chrome/installer/gcapi_mac/gcapi.mm - Issue 10800052: More -Wunused-private-field cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi_mac/gcapi.mm

Issue 10800052: More -Wunused-private-field cleanups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/gcapi_mac/gcapi.mm

diff --git a/chrome/installer/gcapi_mac/gcapi.mm b/chrome/installer/gcapi_mac/gcapi.mm

index bb562899f888d0e3a67d4c5e85c32adb483a76ad..773944964be295f517eedb31d07f977f06199431 100644

--- a/chrome/installer/gcapi_mac/gcapi.mm

+++ b/chrome/installer/gcapi_mac/gcapi.mm

@@ -159,7 +159,7 @@ NSString* WriteData(NSData* data, NSString* system_path, NSString* user_path) {

// setuid root, and in that case the kSystemBrandPath path above should have

// worked anyway. So only try user if geteuid() isn't root.

if (geteuid() != 0) {

- NSString* user_path = [user_path stringByExpandingTildeInPath];

+ user_path = [user_path stringByExpandingTildeInPath];

if (CreatePathToFile(user_path) &&

[data writeToFile:user_path atomically:YES]) {

chmod([user_path fileSystemRepresentation], Permissions() & ~0111);