base: Make ScopedVector::clear() destroy elements.

base: Make ScopedVector::clear() destroy elements.

This makes ScopedVector's clear() method destroy the
elements before clearing the internal vector, matching the
behavior of the erase() method.  I'm moving clear()'s
previous element-preserving behavior into a new weak_clear()
method, matching weak_erase().

I'm also removing ScopedVector::reset(), as it duplicated
clear()'s new behavior and isn't a part of std::vector.

BUG=137909
TEST=added


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147360

[Daniel Erat, 2012-07-18 20:52:39]

brettw -> base
sky -> ui

Patch set 1 is just a rename of clear() to weak_clear().  The Chrome OS build
compiled locally, but I started some try jobs to hopefully catch any additional
callers of clear() that expect the old behavior.

[sky, 2012-07-18 21:24:38]

LGTM

http://codereview.chromium.org/10797017/diff/7001/base/memory/scoped_vector.h
File base/memory/scoped_vector.h (right):

http://codereview.chromium.org/10797017/diff/7001/base/memory/scoped_vector.h...
base/memory/scoped_vector.h:85: void clear() { STLDeleteElements(&v); }
Any chance we could get rid of one of reset or clear?

[Peter Kasting, 2012-07-18 21:26:32]

http://codereview.chromium.org/10797017/diff/7001/base/memory/scoped_vector.h
File base/memory/scoped_vector.h (right):

http://codereview.chromium.org/10797017/diff/7001/base/memory/scoped_vector.h...
base/memory/scoped_vector.h:85: void clear() { STLDeleteElements(&v); }
On 2012/07/18 21:24:38, sky wrote:
> Any chance we could get rid of one of reset or clear?

(I suggest nuking reset())

[Daniel Erat, 2012-07-18 21:32:37]

On 2012/07/18 21:26:32, Peter Kasting wrote:
> http://codereview.chromium.org/10797017/diff/7001/base/memory/scoped_vector.h
> File base/memory/scoped_vector.h (right):
> 
>
http://codereview.chromium.org/10797017/diff/7001/base/memory/scoped_vector.h...
> base/memory/scoped_vector.h:85: void clear() { STLDeleteElements(&v); }
> On 2012/07/18 21:24:38, sky wrote:
> > Any chance we could get rid of one of reset or clear?
> 
> (I suggest nuking reset())

Sure, in-progress (Brett suggested the same thing).

[Daniel Erat, 2012-07-18 21:55:03]

willchan -> net, chrome/browser/net
akalin -> chrome/browser/sync

[willchan no longer on Chromium, 2012-07-18 22:00:37]

Thanks for the change. LGTM.

[akalin, 2012-07-18 22:00:45]

sync lgtm

[brettw, 2012-07-18 22:01:50]

LGTM in case you still need me.

[commit-bot: I haz the power, 2012-07-18 23:33:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10797017/10002

[commit-bot: I haz the power, 2012-07-19 00:39:02]

Change committed as 147360