Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Side by Side Diff: chrome/browser/password_manager/password_manager.cc

Issue 10797017: base: Make ScopedVector::clear() destroy elements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update location_bar_view_mac.mm Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_manager.h" 5 #include "chrome/browser/password_manager/password_manager.h"
6 6
7 #include "base/threading/platform_thread.h" 7 #include "base/threading/platform_thread.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/password_manager/password_form_manager.h" 9 #include "chrome/browser/password_manager/password_form_manager.h"
10 #include "chrome/browser/password_manager/password_manager_delegate.h" 10 #include "chrome/browser/password_manager/password_manager_delegate.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 if (!params.password_form.origin.is_valid()) { 164 if (!params.password_form.origin.is_valid()) {
165 // This codepath essentially means that a frame not containing a password 165 // This codepath essentially means that a frame not containing a password
166 // form was navigated. For example, this might be a subframe of the main 166 // form was navigated. For example, this might be a subframe of the main
167 // page, navigated either automatically or in response to a user action. 167 // page, navigated either automatically or in response to a user action.
168 return; 168 return;
169 } 169 }
170 170
171 // There might be password data to provisionally save. Other than that, we're 171 // There might be password data to provisionally save. Other than that, we're
172 // ready to reset and move on. 172 // ready to reset and move on.
173 ProvisionallySavePassword(params.password_form); 173 ProvisionallySavePassword(params.password_form);
174 pending_login_managers_.reset(); 174 pending_login_managers_.clear();
175 } 175 }
176 176
177 bool PasswordManager::OnMessageReceived(const IPC::Message& message) { 177 bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
178 bool handled = true; 178 bool handled = true;
179 IPC_BEGIN_MESSAGE_MAP(PasswordManager, message) 179 IPC_BEGIN_MESSAGE_MAP(PasswordManager, message)
180 IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormsParsed, 180 IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormsParsed,
181 OnPasswordFormsParsed) 181 OnPasswordFormsParsed)
182 IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormsRendered, 182 IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormsRendered,
183 OnPasswordFormsRendered) 183 OnPasswordFormsRendered)
184 IPC_MESSAGE_UNHANDLED(handled = false) 184 IPC_MESSAGE_UNHANDLED(handled = false)
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 if (observer_) { 271 if (observer_) {
272 observer_->OnAutofillDataAvailable(preferred_match.username_value, 272 observer_->OnAutofillDataAvailable(preferred_match.username_value,
273 preferred_match.password_value); 273 preferred_match.password_value);
274 } 274 }
275 } 275 }
276 } 276 }
277 277
278 bool PasswordManager::IsFillingEnabled() const { 278 bool PasswordManager::IsFillingEnabled() const {
279 return delegate_->GetProfile() && *password_manager_enabled_; 279 return delegate_->GetProfile() && *password_manager_enabled_;
280 } 280 }
OLDNEW
« no previous file with comments | « chrome/browser/net/sqlite_server_bound_cert_store_unittest.cc ('k') | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698