Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 10797017: base: Make ScopedVector::clear() destroy elements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update location_bar_view_mac.mm Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
index 71f56131451846e6a9e7ce603aec0fb05a5fc6e1..3859e58e77db904c69a158ac2105a184a542a282 100644
--- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc
+++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
@@ -739,7 +739,7 @@ void LocationBarViewGtk::UpdatePageActions() {
// loaded or added after startup.
if (new_page_actions != page_actions_) {
page_actions_.swap(new_page_actions);
- page_action_views_.reset();
+ page_action_views_.clear();
for (size_t i = 0; i < page_actions_.size(); ++i) {
page_action_views_.push_back(
@@ -771,7 +771,7 @@ void LocationBarViewGtk::UpdatePageActions() {
void LocationBarViewGtk::InvalidatePageActions() {
size_t count_before = page_action_views_.size();
- page_action_views_.reset();
+ page_action_views_.clear();
if (page_action_views_.size() != count_before) {
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_EXTENSION_PAGE_ACTION_COUNT_CHANGED,
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/views/hung_renderer_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698