Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10796051: Change protoc build rule to not use cygwin bash. (Closed)

Created:
8 years, 5 months ago by iannucci
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Change protoc build rule to not use cygwin bash. Now protoc.exe will be directly invoked. This rolls cacheinvalidation from r218:r219 ------------------------------------------------------------------------ r219 | ghcooper@gmail.com | 2012-07-20 17:44:14 -0700 (Fri, 20 Jul 2012) | 1 line move protos out of v2/; use relative paths for proto imports ------------------------------------------------------------------------ This also rolls gyp from r1440:r1441 ------------------------------------------------------------------------ r1441 | iannucci@chromium.org | 2012-07-26 17:54:17 -0700 (Thu, 26 Jul 2012) | 8 lines Fix bug: non-cygwin actions incorrectly run options through _FixPath. This adds an additional heuristic to the existing one. Now if an option begins with either a '/' OR a '-', it assumes it's not a strict path. Added a TODO which notes that the existing (and new) behavior will miss options such as '--opt=a/posix/path', and '/opt:a/posix/path'. Review URL: https://chromiumcodereview.appspot.com/10829049 ------------------------------------------------------------------------ BUG=123026, 113339 R=scottmg@chromium.org,cmp@chromium.org,nsylvain@chromium.org,jar@chromium.org,akalin@chromium.org,maruel@chromium.org TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149100

Patch Set 1 #

Patch Set 2 : Also make cacheinvalidation use main genproto rule #

Patch Set 3 : Bump gyp up. Everything happy locally now :) #

Patch Set 4 : Fix the additional paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -85 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M build/protoc.gypi View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M sync/notifier/chrome_invalidation_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/chrome_invalidation_client_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/push_client_channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_notifier_helper_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/cacheinvalidation/README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 1 chunk +11 lines, -72 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
akalin
lgtm mention the cacheinvalidation roll in the CL description
8 years, 5 months ago (2012-07-24 04:35:40 UTC) #1
iannucci
8 years, 4 months ago (2012-07-27 22:35:09 UTC) #2
Ryan Sleevi
On 2012/07/27 22:35:09, iannucci wrote: Please note cacheinvalidation change -> http://crbug.com/113339
8 years, 4 months ago (2012-07-30 06:54:50 UTC) #3
iannucci
On 2012/07/30 06:54:50, Ryan Sleevi wrote: > On 2012/07/27 22:35:09, iannucci wrote: > > Please ...
8 years, 4 months ago (2012-07-30 18:35:08 UTC) #4
iannucci
PTAL, when you have a minute. Subject says it all :) Thanks, Robbie
8 years, 4 months ago (2012-07-30 18:35:40 UTC) #5
scottmg
Looks fine to me, and akalin already said so? In general try to only specify ...
8 years, 4 months ago (2012-07-30 19:03:55 UTC) #6
iannucci
On 2012/07/30 19:03:55, scottmg wrote: > Looks fine to me, and akalin already said so? ...
8 years, 4 months ago (2012-07-30 20:20:33 UTC) #7
scottmg
OK, lgtm
8 years, 4 months ago (2012-07-30 20:25:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/10796051/11001
8 years, 4 months ago (2012-07-30 20:32:39 UTC) #9
commit-bot: I haz the power
Try job failure for 10796051-11001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-07-30 22:36:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/10796051/21004
8 years, 4 months ago (2012-07-30 23:26:18 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 01:07:34 UTC) #12
Change committed as 149100

Powered by Google App Engine
This is Rietveld 408576698