Fix bug: non-cygwin actions incorrectly run options through _FixPath.

Fix bug: non-cygwin actions incorrectly run options through _FixPath.

This adds an additional heuristic to the existing one. Now if an option begins
with either a '/' OR a '-', it assumes it's not a strict path.

Added a TODO which notes that the existing (and new) behavior will miss options
such as '--opt=a/posix/path', and '/opt:a/posix/path'.
Committed: https://code.google.com/p/gyp/source/detail?r=1441

[iannucci, 2012-07-27 00:19:51]

Just about what it says in the CL description. I was running into an issue where
an option like '--proto-path=some/posix/dir' would turn into '..\\posix\\dir'.
I've changed the gyp build rule to do ['--proto-path', 'some/posix/dir']
instead, and this fixes the issue where _FixPath is called on '--proto-path'.

[scottmg, 2012-07-27 00:31:49]

That is yuck. lgtm.

https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
File pylib/gyp/generator/msvs.py (right):

https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
pylib/gyp/generator/msvs.py:302: arguments = [i if (i[:1] in "/-") else
_FixPath(i) for i in cmd[1:]]
i[0] instead of i[:1]

[iannucci, 2012-07-27 00:33:20]

On 2012/07/27 00:31:49, scottmg wrote:
> That is yuck. lgtm.
> 
>
https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
> File pylib/gyp/generator/msvs.py (right):
> 
>
https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
> pylib/gyp/generator/msvs.py:302: arguments = [i if (i[:1] in "/-") else
> _FixPath(i) for i in cmd[1:]]
> i[0] instead of i[:1]

Ah ha! But what if i == '' ? ;-)

[scottmg, 2012-07-27 00:35:41]

On 2012/07/27 00:33:20, iannucci wrote:
> On 2012/07/27 00:31:49, scottmg wrote:
> > That is yuck. lgtm.
> > 
> >
>
https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
> > File pylib/gyp/generator/msvs.py (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
> > pylib/gyp/generator/msvs.py:302: arguments = [i if (i[:1] in "/-") else
> > _FixPath(i) for i in cmd[1:]]
> > i[0] instead of i[:1]
> 
> Ah ha! But what if i == '' ? ;-)

Do we get empty paths there? :/ If so, sorry for suggesting a bug.

[iannucci, 2012-07-27 00:38:54]

On 2012/07/27 00:35:41, scottmg wrote:
> On 2012/07/27 00:33:20, iannucci wrote:
> > On 2012/07/27 00:31:49, scottmg wrote:
> > > That is yuck. lgtm.
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
> > > File pylib/gyp/generator/msvs.py (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10829049/diff/1/pylib/gyp/generator/ms...
> > > pylib/gyp/generator/msvs.py:302: arguments = [i if (i[:1] in "/-") else
> > > _FixPath(i) for i in cmd[1:]]
> > > i[0] instead of i[:1]
> > 
> > Ah ha! But what if i == '' ? ;-)
> 
> Do we get empty paths there? :/ If so, sorry for suggesting a bug.

Yeah I tried i[0] originally, and IndexError'd out. We do apparently get some
empty paths here. I'm not entirely sure which rules cause them, but I can
imagine them even being intentional:

  thing-like-sed -i '' ...

(sed doesn't actually use that syntax... but you get the idea).

[Sheridan Rawlins, 2012-07-27 01:12:38]

lgtm