Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: third_party/cacheinvalidation/cacheinvalidation.gyp

Issue 10796051: Change protoc build rule to not use cygwin bash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the additional paths Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/cacheinvalidation/README.chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cacheinvalidation/cacheinvalidation.gyp
diff --git a/third_party/cacheinvalidation/cacheinvalidation.gyp b/third_party/cacheinvalidation/cacheinvalidation.gyp
index 6e4c03e42fc796dbfe0a1b4632af8e3e97e07ca4..77e3c527820c21cb0c6c626fe952317f10891703 100644
--- a/third_party/cacheinvalidation/cacheinvalidation.gyp
+++ b/third_party/cacheinvalidation/cacheinvalidation.gyp
@@ -7,94 +7,33 @@
# This library should build cleanly with the extra warnings turned on
# for Chromium.
'chromium_code': 1,
- # The root directory for the proto files.
- 'proto_dir_root': 'files/src',
# The relative path of the cacheinvalidation proto files from
- # proto_dir_root.
+ # 'files/src'.
# TODO(akalin): Add a RULE_INPUT_DIR predefined variable to gyp so
# we don't need this variable.
- # TODO(ghc): Remove v2/ dir and move all files up a level.
- 'proto_dir_relpath': 'google/cacheinvalidation/v2',
+ 'proto_dir_relpath': 'google/cacheinvalidation',
# Where files generated from proto files are put.
- 'protoc_out_dir': '<(SHARED_INTERMEDIATE_DIR)/protoc_out',
- # The path to the protoc executable.
- 'protoc': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)protoc<(EXECUTABLE_SUFFIX)',
+ 'proto_in_dir': 'files/src/<(proto_dir_relpath)',
+ 'proto_out_dir': '<(proto_dir_relpath)',
},
'targets': [
- # The rule/action to generate files from the cacheinvalidation proto
- # files.
- {
- 'target_name': 'cacheinvalidation_proto',
- 'type': 'none',
- 'sources': [
- '<(proto_dir_root)/<(proto_dir_relpath)/client.proto',
- '<(proto_dir_root)/<(proto_dir_relpath)/client_gateway.proto',
- '<(proto_dir_root)/<(proto_dir_relpath)/client_protocol.proto',
- '<(proto_dir_root)/<(proto_dir_relpath)/client_test_internal.proto',
- '<(proto_dir_root)/<(proto_dir_relpath)/types.proto',
- ],
- # TODO(akalin): This block was copied from the sync_proto target
- # from chrome.gyp. Decomp the shared blocks out somehow.
- 'rules': [
- {
- 'rule_name': 'genproto',
- 'extension': 'proto',
- 'inputs': [
- '<(protoc)',
- ],
- 'outputs': [
- '<(protoc_out_dir)/<(proto_dir_relpath)/<(RULE_INPUT_ROOT).pb.h',
- '<(protoc_out_dir)/<(proto_dir_relpath)/<(RULE_INPUT_ROOT).pb.cc',
- ],
- 'action': [
- '<(protoc)',
- '--proto_path=<(proto_dir_root)',
- # This path needs to be prefixed by proto_path, so we can't
- # use RULE_INPUT_PATH (which is an absolute path).
- '<(proto_dir_root)/<(proto_dir_relpath)/<(RULE_INPUT_NAME)',
- '--cpp_out=<(protoc_out_dir)',
- ],
- 'message': 'Generating C++ code from <(RULE_INPUT_PATH)',
- },
- ],
- 'dependencies': [
- '../../third_party/protobuf/protobuf.gyp:protoc#host',
- ],
- },
# The C++ files generated from the cache invalidation protocol buffers.
{
'target_name': 'cacheinvalidation_proto_cpp',
'type': 'static_library',
'sources': [
- '<(protoc_out_dir)/<(proto_dir_relpath)/client.pb.h',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client.pb.cc',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client_gateway.pb.h',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client_gateway.pb.cc',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client_protocol.pb.h',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client_protocol.pb.cc',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client_test_internal.pb.h',
- '<(protoc_out_dir)/<(proto_dir_relpath)/client_test_internal.pb.cc',
- '<(protoc_out_dir)/<(proto_dir_relpath)/types.pb.h',
- '<(protoc_out_dir)/<(proto_dir_relpath)/types.pb.cc',
- ],
- 'dependencies': [
- '../../third_party/protobuf/protobuf.gyp:protobuf_lite',
- 'cacheinvalidation_proto',
- ],
- 'include_dirs': [
- '<(protoc_out_dir)',
+ '<(proto_in_dir)/client.proto',
+ '<(proto_in_dir)/client_gateway.proto',
+ '<(proto_in_dir)/client_protocol.proto',
+ '<(proto_in_dir)/client_test_internal.proto',
+ '<(proto_in_dir)/types.proto',
],
+ 'includes': [ '../../build/protoc.gypi' ],
'direct_dependent_settings': {
'include_dirs': [
- '<(protoc_out_dir)',
+ '<(proto_out_dir)',
],
},
- 'export_dependent_settings': [
- '../../third_party/protobuf/protobuf.gyp:protobuf_lite',
- ],
- # This target exports a hard dependency because it contains generated
- # header files.
- 'hard_dependency': 1,
},
# The main cache invalidation library. External clients should depend
# only on this.
« no previous file with comments | « third_party/cacheinvalidation/README.chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698