Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10795090: Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused… (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jam, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, dcheng, kinuko+watch, Ilya Sherman, markusheintz_, cbentzel+watch_chromium.org, kkania, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, dbeam+watch-ntp_chromium.org, jennb, dyu1, jianli, gavinp+prer_chromium.org, mihaip-chromium-reviews_chromium.org, Dmitry Titov, Aaron Boodman, dominich+watch_chromium.org, robertshield, rdsmith+dwatch_chromium.org, estade+watch_chromium.org, mmenke
Visibility:
Public.

Description

Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -394 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/automation/automation_misc_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/browser_tag_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_management_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 11 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/subscribe_page_action_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/web_contents_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_install_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 4 chunks +1 line, -131 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 25 chunks +26 lines, -25 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +29 lines, -0 lines 0 comments Download
M content/test/browser_test_utils.cc View 3 chunks +162 lines, -26 lines 0 comments Download
M content/test/layout_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 5 months ago (2012-07-24 16:36:05 UTC) #1
scottmg
8 years, 5 months ago (2012-07-24 16:42:58 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698