Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: chrome/browser/loadtimes_extension_bindings_browsertest.cc

Issue 10795090: Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 #include "chrome/browser/ui/browser_tabstrip.h" 6 #include "chrome/browser/ui/browser_tabstrip.h"
7 #include "chrome/test/base/in_process_browser_test.h" 7 #include "chrome/test/base/in_process_browser_test.h"
8 #include "chrome/test/base/ui_test_utils.h" 8 #include "chrome/test/base/ui_test_utils.h"
9 #include "content/public/browser/web_contents.h" 9 #include "content/public/browser/web_contents.h"
10 #include "content/public/test/browser_test_utils.h"
10 #include "net/test/test_server.h" 11 #include "net/test/test_server.h"
11 12
12 class LoadtimesExtensionBindingsTest : public InProcessBrowserTest { 13 class LoadtimesExtensionBindingsTest : public InProcessBrowserTest {
13 public: 14 public:
14 LoadtimesExtensionBindingsTest() {} 15 LoadtimesExtensionBindingsTest() {}
15 16
16 void CompareBeforeAndAfter() { 17 void CompareBeforeAndAfter() {
17 // TODO(simonjam): There's a race on whether or not first paint is populated 18 // TODO(simonjam): There's a race on whether or not first paint is populated
18 // before we read them. We ought to test that too. Until the race is fixed, 19 // before we read them. We ought to test that too. Until the race is fixed,
19 // zero it out so the test is stable. 20 // zero it out so the test is stable.
20 content::RenderViewHost* rvh = 21 content::RenderViewHost* rvh =
21 chrome::GetActiveWebContents(browser())->GetRenderViewHost(); 22 chrome::GetActiveWebContents(browser())->GetRenderViewHost();
22 ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( 23 ASSERT_TRUE(content::ExecuteJavaScript(
23 rvh, L"", 24 rvh, L"",
24 L"window.before.firstPaintAfterLoadTime = 0;" 25 L"window.before.firstPaintAfterLoadTime = 0;"
25 L"window.before.firstPaintTime = 0;" 26 L"window.before.firstPaintTime = 0;"
26 L"window.after.firstPaintAfterLoadTime = 0;" 27 L"window.after.firstPaintAfterLoadTime = 0;"
27 L"window.after.firstPaintTime = 0;")); 28 L"window.after.firstPaintTime = 0;"));
28 29
29 std::string before; 30 std::string before;
30 std::string after; 31 std::string after;
31 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( 32 ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
32 rvh, L"", L"window.domAutomationController.send(" 33 rvh, L"", L"window.domAutomationController.send("
33 L"JSON.stringify(before))", &before)); 34 L"JSON.stringify(before))", &before));
34 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( 35 ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
35 rvh, L"", L"window.domAutomationController.send(" 36 rvh, L"", L"window.domAutomationController.send("
36 L"JSON.stringify(after))", &after)); 37 L"JSON.stringify(after))", &after));
37 EXPECT_EQ(before, after); 38 EXPECT_EQ(before, after);
38 } 39 }
39 }; 40 };
40 41
41 IN_PROC_BROWSER_TEST_F(LoadtimesExtensionBindingsTest, 42 IN_PROC_BROWSER_TEST_F(LoadtimesExtensionBindingsTest,
42 LoadTimesSameAfterClientInDocNavigation) { 43 LoadTimesSameAfterClientInDocNavigation) {
43 ASSERT_TRUE(test_server()->Start()); 44 ASSERT_TRUE(test_server()->Start());
44 GURL plain_url = test_server()->GetURL("blank"); 45 GURL plain_url = test_server()->GetURL("blank");
45 ui_test_utils::NavigateToURL(browser(), plain_url); 46 ui_test_utils::NavigateToURL(browser(), plain_url);
46 content::RenderViewHost* rvh = 47 content::RenderViewHost* rvh =
47 chrome::GetActiveWebContents(browser())->GetRenderViewHost(); 48 chrome::GetActiveWebContents(browser())->GetRenderViewHost();
48 ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( 49 ASSERT_TRUE(content::ExecuteJavaScript(
49 rvh, L"", L"window.before = window.chrome.loadTimes()")); 50 rvh, L"", L"window.before = window.chrome.loadTimes()"));
50 ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( 51 ASSERT_TRUE(content::ExecuteJavaScript(
51 rvh, L"", L"window.location.href = window.location + \"#\"")); 52 rvh, L"", L"window.location.href = window.location + \"#\""));
52 ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( 53 ASSERT_TRUE(content::ExecuteJavaScript(
53 rvh, L"", L"window.after = window.chrome.loadTimes()")); 54 rvh, L"", L"window.after = window.chrome.loadTimes()"));
54 CompareBeforeAndAfter(); 55 CompareBeforeAndAfter();
55 } 56 }
56 57
57 IN_PROC_BROWSER_TEST_F(LoadtimesExtensionBindingsTest, 58 IN_PROC_BROWSER_TEST_F(LoadtimesExtensionBindingsTest,
58 LoadTimesSameAfterUserInDocNavigation) { 59 LoadTimesSameAfterUserInDocNavigation) {
59 ASSERT_TRUE(test_server()->Start()); 60 ASSERT_TRUE(test_server()->Start());
60 GURL plain_url = test_server()->GetURL("blank"); 61 GURL plain_url = test_server()->GetURL("blank");
61 GURL hash_url(plain_url.spec() + "#"); 62 GURL hash_url(plain_url.spec() + "#");
62 ui_test_utils::NavigateToURL(browser(), plain_url); 63 ui_test_utils::NavigateToURL(browser(), plain_url);
63 content::RenderViewHost* rvh = 64 content::RenderViewHost* rvh =
64 chrome::GetActiveWebContents(browser())->GetRenderViewHost(); 65 chrome::GetActiveWebContents(browser())->GetRenderViewHost();
65 ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( 66 ASSERT_TRUE(content::ExecuteJavaScript(
66 rvh, L"", L"window.before = window.chrome.loadTimes()")); 67 rvh, L"", L"window.before = window.chrome.loadTimes()"));
67 ui_test_utils::NavigateToURL(browser(), hash_url); 68 ui_test_utils::NavigateToURL(browser(), hash_url);
68 ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( 69 ASSERT_TRUE(content::ExecuteJavaScript(
69 rvh, L"", L"window.after = window.chrome.loadTimes()")); 70 rvh, L"", L"window.after = window.chrome.loadTimes()"));
70 CompareBeforeAndAfter(); 71 CompareBeforeAndAfter();
71 } 72 }
OLDNEW
« no previous file with comments | « chrome/browser/instant/instant_browsertest.cc ('k') | chrome/browser/net/load_timing_observer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698