Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: chrome/browser/extensions/extension_nacl_browsertest.cc

Issue 10795090: Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/extensions/crx_installer.h" 9 #include "chrome/browser/extensions/crx_installer.h"
10 #include "chrome/browser/extensions/extension_browsertest.h" 10 #include "chrome/browser/extensions/extension_browsertest.h"
11 #include "chrome/browser/extensions/extension_service.h" 11 #include "chrome/browser/extensions/extension_service.h"
12 #include "chrome/browser/prefs/pref_service.h" 12 #include "chrome/browser/prefs/pref_service.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/browser_tabstrip.h" 15 #include "chrome/browser/ui/browser_tabstrip.h"
16 #include "chrome/common/chrome_paths.h" 16 #include "chrome/common/chrome_paths.h"
17 #include "chrome/common/chrome_switches.h" 17 #include "chrome/common/chrome_switches.h"
18 #include "chrome/common/pref_names.h" 18 #include "chrome/common/pref_names.h"
19 #include "chrome/test/base/ui_test_utils.h" 19 #include "chrome/test/base/ui_test_utils.h"
20 #include "content/public/browser/plugin_service.h" 20 #include "content/public/browser/plugin_service.h"
21 #include "content/public/browser/web_contents.h" 21 #include "content/public/browser/web_contents.h"
22 #include "content/public/test/browser_test_utils.h"
22 #include "webkit/plugins/webplugininfo.h" 23 #include "webkit/plugins/webplugininfo.h"
23 24
24 using content::PluginService; 25 using content::PluginService;
25 using content::WebContents; 26 using content::WebContents;
26 using extensions::Extension; 27 using extensions::Extension;
27 28
28 namespace { 29 namespace {
29 30
30 const char* kExtensionId = "bjjcibdiodkkeanflmiijlcfieiemced"; 31 const char* kExtensionId = "bjjcibdiodkkeanflmiijlcfieiemced";
31 32
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 void CheckPluginsCreated(const Extension* extension, bool should_create) { 93 void CheckPluginsCreated(const Extension* extension, bool should_create) {
93 ui_test_utils::NavigateToURL(browser(), 94 ui_test_utils::NavigateToURL(browser(),
94 extension->GetResourceURL("test.html")); 95 extension->GetResourceURL("test.html"));
95 // Don't run tests if the NaCl plugin isn't loaded. 96 // Don't run tests if the NaCl plugin isn't loaded.
96 if (!IsNaClPluginLoaded()) 97 if (!IsNaClPluginLoaded())
97 return; 98 return;
98 99
99 bool embedded_plugin_created = false; 100 bool embedded_plugin_created = false;
100 bool content_handler_plugin_created = false; 101 bool content_handler_plugin_created = false;
101 WebContents* web_contents = chrome::GetActiveWebContents(browser()); 102 WebContents* web_contents = chrome::GetActiveWebContents(browser());
102 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( 103 ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(
103 web_contents->GetRenderViewHost(), L"", 104 web_contents->GetRenderViewHost(), L"",
104 L"window.domAutomationController.send(EmbeddedPluginCreated());", 105 L"window.domAutomationController.send(EmbeddedPluginCreated());",
105 &embedded_plugin_created)); 106 &embedded_plugin_created));
106 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( 107 ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(
107 web_contents->GetRenderViewHost(), L"", 108 web_contents->GetRenderViewHost(), L"",
108 L"window.domAutomationController.send(ContentHandlerPluginCreated());", 109 L"window.domAutomationController.send(ContentHandlerPluginCreated());",
109 &content_handler_plugin_created)); 110 &content_handler_plugin_created));
110 111
111 EXPECT_EQ(should_create, embedded_plugin_created); 112 EXPECT_EQ(should_create, embedded_plugin_created);
112 EXPECT_EQ(should_create, content_handler_plugin_created); 113 EXPECT_EQ(should_create, content_handler_plugin_created);
113 } 114 }
114 }; 115 };
115 116
116 // Test that the NaCl plugin isn't blocked for Webstore extensions. 117 // Test that the NaCl plugin isn't blocked for Webstore extensions.
(...skipping 28 matching lines...) Expand all
145 IN_PROC_BROWSER_TEST_F(NaClExtensionTest, UnpackedExtension) { 146 IN_PROC_BROWSER_TEST_F(NaClExtensionTest, UnpackedExtension) {
146 ASSERT_TRUE(test_server()->Start()); 147 ASSERT_TRUE(test_server()->Start());
147 148
148 const Extension* extension = InstallExtension(INSTALL_TYPE_UNPACKED); 149 const Extension* extension = InstallExtension(INSTALL_TYPE_UNPACKED);
149 ASSERT_TRUE(extension); 150 ASSERT_TRUE(extension);
150 ASSERT_EQ(extension->location(), Extension::LOAD); 151 ASSERT_EQ(extension->location(), Extension::LOAD);
151 CheckPluginsCreated(extension, true); 152 CheckPluginsCreated(extension, true);
152 } 153 }
153 154
154 } // namespace 155 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698