Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 10795037: Revert 147328 - Current status of patch: (Closed)

Created:
8 years, 5 months ago by greggman
Modified:
8 years, 5 months ago
Reviewers:
dmurph
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Revert 147328 - Current status of patch: - In-memory cache - maximum in memory limit (currently 6mb) - lru eviction - Cache includes saving the attribute + uniform mappings Wiring: - Added bindings for glProgramBinary and glGetProgramBinary - Plumbed the shader cache from gl_channel_manager to program_manager Refactoring: - moved the meat of DoCompile to the ProgramManager New: - added field to ShaderInfo to store if we have a possible pending cache compile - exposed attrib_map and uniform_map in ShaderInfo for the cache - program_cache base class with in-memory status storage - Simple memory_program_cache implementation, stores programs with lru eviction - Added caching logic to DoCompileShader in gles2_cmd_decoder and Link in program_manager Design doc: https://docs.google.com/document/d/1Vceem-nF4TCICoeGSh7OMXxfGuJEJYblGXRgN9V9hcE/edit BUG=88572 Review URL: https://chromiumcodereview.appspot.com/10534173 TBR=dmurph@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -2219 lines) Patch
M content/common/gpu/gpu_channel.h View 4 chunks +1 line, -8 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gl_mock.h View 2 chunks +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 3 chunks +1 line, -5 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 4 chunks +2 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +47 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 3 chunks +3 lines, -5 lines 0 comments Download
D gpu/command_buffer/service/memory_program_cache.h View 1 chunk +0 lines, -88 lines 0 comments Download
D gpu/command_buffer/service/memory_program_cache.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D gpu/command_buffer/service/memory_program_cache_unittest.cc View 1 chunk +0 lines, -379 lines 0 comments Download
M gpu/command_buffer/service/mocks.h View 3 chunks +1 line, -22 lines 0 comments Download
M gpu/command_buffer/service/mocks.cc View 2 chunks +1 line, -4 lines 0 comments Download
D gpu/command_buffer/service/program_cache.h View 1 chunk +0 lines, -122 lines 0 comments Download
D gpu/command_buffer/service/program_cache.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D gpu/command_buffer/service/program_cache_lru_helper.h View 1 chunk +0 lines, -51 lines 0 comments Download
D gpu/command_buffer/service/program_cache_lru_helper.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D gpu/command_buffer/service/program_cache_lru_helper_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D gpu/command_buffer/service/program_cache_unittest.cc View 1 chunk +0 lines, -249 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 9 chunks +5 lines, -31 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 7 chunks +5 lines, -164 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 10 chunks +10 lines, -378 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 4 chunks +0 lines, -54 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 2 chunks +1 line, -5 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 2 chunks +3 lines, -35 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 4 chunks +9 lines, -20 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M gpu/command_buffer_service.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M gpu/demos/framework/window.cc View 2 chunks +1 line, -5 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/gpu_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/generate_bindings.py View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gl/gl_interface.h View 2 chunks +0 lines, -11 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
greggman
8 years, 5 months ago (2012-07-19 18:51:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698