[Sync] Remove unneeded 'using syncer::' lines and 'syncer::' scopings

[Sync] Remove unneeded 'using syncer::' lines and 'syncer::' scopings

Since (almost) everything in sync/ is now in the 'syncer' namespace,
all of these are redundant.

Clean up indentation.

Put sync_{client,listen_notifications} into syncer namespace.

BUG=128060
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147675

[akalin, 2012-07-18 22:45:04]

+zea for review

[Nicolas Zea, 2012-07-19 19:37:55]

Mainly nits, but looks like linux_rel has a legit compile failure?

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/base_node.cc
File sync/internal_api/base_node.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/base_node...
sync/internal_api/base_node.cc:125: ModelTypeToString(GetModelType()) << ".";
nit: fix up indent

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/base_node...
sync/internal_api/base_node.cc:286: DCHECK_EQ(GetModelType(), APPS);
nit: these should be the other way around right? i.e.: expected value, test
value

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/ba...
File sync/internal_api/public/base_node.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/ba...
sync/internal_api/public/base_node.h:205: static std::string
GenerateSyncableHash(ModelType model_type,
nit: move first arg to newline

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/te...
File sync/internal_api/public/test/test_entry_factory.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/te...
sync/internal_api/public/test/test_entry_factory.h:56: int64
CreateSyncedItem(const std::string& name, ModelType
second arg on own line

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/sync_mana...
File sync/internal_api/sync_manager_impl.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/sync_mana...
sync/internal_api/sync_manager_impl.cc:1874: GetModelTypeFromSpecifics(
move onto previous line?

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/sync_mana...
sync/internal_api/sync_manager_impl.cc:1948: GetModelTypeFromSpecifics(
here too

http://codereview.chromium.org/10795018/diff/2001/sync/syncable/mutable_entry.h
File sync/syncable/mutable_entry.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/syncable/mutable_entry...
sync/syncable/mutable_entry.h:90: friend class WriteNode;
move one line up.

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_client.cc
File sync/tools/sync_client.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_client.cc#n...
sync/tools/sync_client.cc:258: using namespace syncer;
I think style guide forbids this usage?

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_listen_noti...
File sync/tools/sync_listen_notifications.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_listen_noti...
sync/tools/sync_listen_notifications.cc:183: using namespace syncer;
here too

http://codereview.chromium.org/10795018/diff/2001/sync/util/data_type_histogr...
File sync/util/data_type_histogram.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/util/data_type_histogr...
sync/util/data_type_histogram.h:86: << ModelTypeToString(datatype); \
should this be ::syncer too?

[akalin, 2012-07-19 20:56:02]

PTAL

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/base_node.cc
File sync/internal_api/base_node.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/base_node...
sync/internal_api/base_node.cc:125: ModelTypeToString(GetModelType()) << ".";
On 2012/07/19 19:37:56, nzea wrote:
> nit: fix up indent

Done.

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/base_node...
sync/internal_api/base_node.cc:286: DCHECK_EQ(GetModelType(), APPS);
On 2012/07/19 19:37:56, nzea wrote:
> nit: these should be the other way around right? i.e.: expected value, test
> value

that's only for gtest functions (EXPECT_EQ, ASSERT_EQ)

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/ba...
File sync/internal_api/public/base_node.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/ba...
sync/internal_api/public/base_node.h:205: static std::string
GenerateSyncableHash(ModelType model_type,
On 2012/07/19 19:37:56, nzea wrote:
> nit: move first arg to newline

Done.

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/te...
File sync/internal_api/public/test/test_entry_factory.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/public/te...
sync/internal_api/public/test/test_entry_factory.h:56: int64
CreateSyncedItem(const std::string& name, ModelType
On 2012/07/19 19:37:56, nzea wrote:
> second arg on own line

Done.

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/sync_mana...
File sync/internal_api/sync_manager_impl.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/sync_mana...
sync/internal_api/sync_manager_impl.cc:1874: GetModelTypeFromSpecifics(
On 2012/07/19 19:37:56, nzea wrote:
> move onto previous line?

Done.

http://codereview.chromium.org/10795018/diff/2001/sync/internal_api/sync_mana...
sync/internal_api/sync_manager_impl.cc:1948: GetModelTypeFromSpecifics(
On 2012/07/19 19:37:56, nzea wrote:
> here too

Done.

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_client.cc
File sync/tools/sync_client.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_client.cc#n...
sync/tools/sync_client.cc:258: using namespace syncer;
On 2012/07/19 19:37:56, nzea wrote:
> I think style guide forbids this usage?

Done, did what I wanted some other way

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_listen_noti...
File sync/tools/sync_listen_notifications.cc (right):

http://codereview.chromium.org/10795018/diff/2001/sync/tools/sync_listen_noti...
sync/tools/sync_listen_notifications.cc:183: using namespace syncer;
On 2012/07/19 19:37:56, nzea wrote:
> here too

Done.

http://codereview.chromium.org/10795018/diff/2001/sync/util/data_type_histogr...
File sync/util/data_type_histogram.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/util/data_type_histogr...
sync/util/data_type_histogram.h:86: << ModelTypeToString(datatype); \
On 2012/07/19 19:37:56, nzea wrote:
> should this be ::syncer too?

Done.

[akalin, 2012-07-19 20:57:23]

http://codereview.chromium.org/10795018/diff/2001/sync/syncable/mutable_entry.h
File sync/syncable/mutable_entry.h (right):

http://codereview.chromium.org/10795018/diff/2001/sync/syncable/mutable_entry...
sync/syncable/mutable_entry.h:90: friend class WriteNode;
On 2012/07/19 19:37:56, nzea wrote:
> move one line up.

moot, now that I added syncer:: back

[Nicolas Zea, 2012-07-19 21:15:15]

LGTM!

[commit-bot: I haz the power, 2012-07-19 21:37:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10795018/11001

[commit-bot: I haz the power, 2012-07-19 23:47:14]

Failed to apply patch for sync/engine/sync_scheduler.cc:
While running patch -p1 --forward --force;
patching file sync/engine/sync_scheduler.cc
Hunk #1 FAILED at 31.
Hunk #2 FAILED at 59.
Hunk #3 FAILED at 70.
Hunk #4 FAILED at 314.
Hunk #5 FAILED at 345.
Hunk #6 FAILED at 447.
Hunk #7 FAILED at 586.
Hunk #8 FAILED at 603.
Hunk #9 FAILED at 624.
9 out of 9 hunks FAILED -- saving rejects to file
sync/engine/sync_scheduler.cc.rej

[commit-bot: I haz the power, 2012-07-20 00:18:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10795018/9009

[commit-bot: I haz the power, 2012-07-20 01:29:49]

Failed to apply patch for sync/internal_api/public/sync_manager.h:
While running patch -p1 --forward --force;
patching file sync/internal_api/public/sync_manager.h
Hunk #12 FAILED at 506.
1 out of 12 hunks FAILED -- saving rejects to file
sync/internal_api/public/sync_manager.h.rej

[commit-bot: I haz the power, 2012-07-20 07:30:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10795018/340

[commit-bot: I haz the power, 2012-07-20 08:39:48]

Try job failure for 10795018-340 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-20 16:00:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10795018/340

[commit-bot: I haz the power, 2012-07-20 17:25:44]

Change committed as 147675