Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: sync/internal_api/js_mutation_event_observer.cc

Issue 10795018: [Sync] Remove unneeded 'using syncer::' lines and 'syncer::' scopings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fiix indent Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/js_mutation_event_observer.h" 5 #include "sync/internal_api/js_mutation_event_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 26 matching lines...) Expand all
37 37
38 namespace { 38 namespace {
39 39
40 // Max number of changes we attempt to convert to values (to avoid 40 // Max number of changes we attempt to convert to values (to avoid
41 // running out of memory). 41 // running out of memory).
42 const size_t kChangeLimit = 100; 42 const size_t kChangeLimit = 100;
43 43
44 } // namespace 44 } // namespace
45 45
46 void JsMutationEventObserver::OnChangesApplied( 46 void JsMutationEventObserver::OnChangesApplied(
47 syncer::ModelType model_type, 47 ModelType model_type,
48 int64 write_transaction_id, 48 int64 write_transaction_id,
49 const syncer::ImmutableChangeRecordList& changes) { 49 const ImmutableChangeRecordList& changes) {
50 if (!event_handler_.IsInitialized()) { 50 if (!event_handler_.IsInitialized()) {
51 return; 51 return;
52 } 52 }
53 DictionaryValue details; 53 DictionaryValue details;
54 details.SetString("modelType", syncer::ModelTypeToString(model_type)); 54 details.SetString("modelType", ModelTypeToString(model_type));
55 details.SetString("writeTransactionId", 55 details.SetString("writeTransactionId",
56 base::Int64ToString(write_transaction_id)); 56 base::Int64ToString(write_transaction_id));
57 base::Value* changes_value = NULL; 57 base::Value* changes_value = NULL;
58 const size_t changes_size = changes.Get().size(); 58 const size_t changes_size = changes.Get().size();
59 if (changes_size <= kChangeLimit) { 59 if (changes_size <= kChangeLimit) {
60 ListValue* changes_list = new ListValue(); 60 ListValue* changes_list = new ListValue();
61 for (syncer::ChangeRecordList::const_iterator it = 61 for (ChangeRecordList::const_iterator it =
62 changes.Get().begin(); it != changes.Get().end(); ++it) { 62 changes.Get().begin(); it != changes.Get().end(); ++it) {
63 changes_list->Append(it->ToValue()); 63 changes_list->Append(it->ToValue());
64 } 64 }
65 changes_value = changes_list; 65 changes_value = changes_list;
66 } else { 66 } else {
67 changes_value = 67 changes_value =
68 Value::CreateStringValue( 68 Value::CreateStringValue(
69 base::Uint64ToString(static_cast<uint64>(changes_size)) + 69 base::Uint64ToString(static_cast<uint64>(changes_size)) +
70 " changes"); 70 " changes");
71 } 71 }
72 details.Set("changes", changes_value); 72 details.Set("changes", changes_value);
73 HandleJsEvent(FROM_HERE, "onChangesApplied", JsEventDetails(&details)); 73 HandleJsEvent(FROM_HERE, "onChangesApplied", JsEventDetails(&details));
74 } 74 }
75 75
76 void JsMutationEventObserver::OnChangesComplete( 76 void JsMutationEventObserver::OnChangesComplete(ModelType model_type) {
77 syncer::ModelType model_type) {
78 if (!event_handler_.IsInitialized()) { 77 if (!event_handler_.IsInitialized()) {
79 return; 78 return;
80 } 79 }
81 DictionaryValue details; 80 DictionaryValue details;
82 details.SetString("modelType", syncer::ModelTypeToString(model_type)); 81 details.SetString("modelType", ModelTypeToString(model_type));
83 HandleJsEvent(FROM_HERE, "onChangesComplete", JsEventDetails(&details)); 82 HandleJsEvent(FROM_HERE, "onChangesComplete", JsEventDetails(&details));
84 } 83 }
85 84
86 void JsMutationEventObserver::OnTransactionWrite( 85 void JsMutationEventObserver::OnTransactionWrite(
87 const syncable::ImmutableWriteTransactionInfo& write_transaction_info, 86 const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
88 syncer::ModelTypeSet models_with_changes) { 87 ModelTypeSet models_with_changes) {
89 DCHECK(CalledOnValidThread()); 88 DCHECK(CalledOnValidThread());
90 if (!event_handler_.IsInitialized()) { 89 if (!event_handler_.IsInitialized()) {
91 return; 90 return;
92 } 91 }
93 DictionaryValue details; 92 DictionaryValue details;
94 details.Set("writeTransactionInfo", 93 details.Set("writeTransactionInfo",
95 write_transaction_info.Get().ToValue(kChangeLimit)); 94 write_transaction_info.Get().ToValue(kChangeLimit));
96 details.Set("modelsWithChanges", 95 details.Set("modelsWithChanges",
97 syncer::ModelTypeSetToValue(models_with_changes)); 96 ModelTypeSetToValue(models_with_changes));
98 HandleJsEvent(FROM_HERE, "onTransactionWrite", JsEventDetails(&details)); 97 HandleJsEvent(FROM_HERE, "onTransactionWrite", JsEventDetails(&details));
99 } 98 }
100 99
101 void JsMutationEventObserver::HandleJsEvent( 100 void JsMutationEventObserver::HandleJsEvent(
102 const tracked_objects::Location& from_here, 101 const tracked_objects::Location& from_here,
103 const std::string& name, const JsEventDetails& details) { 102 const std::string& name, const JsEventDetails& details) {
104 if (!event_handler_.IsInitialized()) { 103 if (!event_handler_.IsInitialized()) {
105 NOTREACHED(); 104 NOTREACHED();
106 return; 105 return;
107 } 106 }
108 event_handler_.Call(from_here, 107 event_handler_.Call(from_here,
109 &JsEventHandler::HandleJsEvent, name, details); 108 &JsEventHandler::HandleJsEvent, name, details);
110 } 109 }
111 110
112 } // namespace syncer 111 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/internal_api/js_mutation_event_observer.h ('k') | sync/internal_api/js_mutation_event_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698