Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: sync/notifier/invalidation_notifier.cc

Issue 10795018: [Sync] Remove unneeded 'using syncer::' lines and 'syncer::' scopings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fiix indent Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/notifier/invalidation_notifier.h ('k') | sync/notifier/invalidation_notifier_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/invalidation_notifier.h" 5 #include "sync/notifier/invalidation_notifier.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/message_loop_proxy.h" 8 #include "base/message_loop_proxy.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "jingle/notifier/listener/push_client.h" 10 #include "jingle/notifier/listener/push_client.h"
11 #include "net/url_request/url_request_context.h" 11 #include "net/url_request/url_request_context.h"
12 #include "sync/internal_api/public/base/model_type_payload_map.h" 12 #include "sync/internal_api/public/base/model_type_payload_map.h"
13 #include "sync/notifier/sync_notifier_observer.h" 13 #include "sync/notifier/sync_notifier_observer.h"
14 #include "talk/xmpp/jid.h" 14 #include "talk/xmpp/jid.h"
15 #include "talk/xmpp/xmppclientsettings.h" 15 #include "talk/xmpp/xmppclientsettings.h"
16 16
17 namespace syncer { 17 namespace syncer {
18 18
19 InvalidationNotifier::InvalidationNotifier( 19 InvalidationNotifier::InvalidationNotifier(
20 scoped_ptr<notifier::PushClient> push_client, 20 scoped_ptr<notifier::PushClient> push_client,
21 const InvalidationVersionMap& initial_max_invalidation_versions, 21 const InvalidationVersionMap& initial_max_invalidation_versions,
22 const std::string& initial_invalidation_state, 22 const std::string& initial_invalidation_state,
23 const syncer::WeakHandle<InvalidationStateTracker>& 23 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
24 invalidation_state_tracker,
25 const std::string& client_info) 24 const std::string& client_info)
26 : state_(STOPPED), 25 : state_(STOPPED),
27 initial_max_invalidation_versions_(initial_max_invalidation_versions), 26 initial_max_invalidation_versions_(initial_max_invalidation_versions),
28 invalidation_state_tracker_(invalidation_state_tracker), 27 invalidation_state_tracker_(invalidation_state_tracker),
29 client_info_(client_info), 28 client_info_(client_info),
30 invalidation_state_(initial_invalidation_state), 29 invalidation_state_(initial_invalidation_state),
31 invalidation_client_(push_client.Pass()) { 30 invalidation_client_(push_client.Pass()) {
32 } 31 }
33 32
34 InvalidationNotifier::~InvalidationNotifier() { 33 InvalidationNotifier::~InvalidationNotifier() {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 invalidation_client_id_, client_info_, invalidation_state_, 78 invalidation_client_id_, client_info_, invalidation_state_,
80 initial_max_invalidation_versions_, 79 initial_max_invalidation_versions_,
81 invalidation_state_tracker_, 80 invalidation_state_tracker_,
82 this); 81 this);
83 invalidation_state_.clear(); 82 invalidation_state_.clear();
84 state_ = STARTED; 83 state_ = STARTED;
85 } 84 }
86 invalidation_client_.UpdateCredentials(email, token); 85 invalidation_client_.UpdateCredentials(email, token);
87 } 86 }
88 87
89 void InvalidationNotifier::UpdateEnabledTypes( 88 void InvalidationNotifier::UpdateEnabledTypes(ModelTypeSet enabled_types) {
90 syncer::ModelTypeSet enabled_types) {
91 DCHECK(CalledOnValidThread()); 89 DCHECK(CalledOnValidThread());
92 CHECK(!invalidation_client_id_.empty()); 90 CHECK(!invalidation_client_id_.empty());
93 ObjectIdSet ids; 91 ObjectIdSet ids;
94 for (syncer::ModelTypeSet::Iterator it = enabled_types.First(); it.Good(); 92 for (ModelTypeSet::Iterator it = enabled_types.First(); it.Good();
95 it.Inc()) { 93 it.Inc()) {
96 invalidation::ObjectId id; 94 invalidation::ObjectId id;
97 if (!RealModelTypeToObjectId(it.Get(), &id)) { 95 if (!RealModelTypeToObjectId(it.Get(), &id)) {
98 DLOG(WARNING) << "Invalid model type " << it.Get(); 96 DLOG(WARNING) << "Invalid model type " << it.Get();
99 continue; 97 continue;
100 } 98 }
101 ids.insert(id); 99 ids.insert(id);
102 } 100 }
103 invalidation_client_.RegisterIds(ids); 101 invalidation_client_.RegisterIds(ids);
104 } 102 }
105 103
106 void InvalidationNotifier::SendNotification( 104 void InvalidationNotifier::SendNotification(ModelTypeSet changed_types) {
107 syncer::ModelTypeSet changed_types) {
108 DCHECK(CalledOnValidThread()); 105 DCHECK(CalledOnValidThread());
109 // Do nothing. 106 // Do nothing.
110 } 107 }
111 108
112 void InvalidationNotifier::OnInvalidate(const ObjectIdPayloadMap& id_payloads) { 109 void InvalidationNotifier::OnInvalidate(const ObjectIdPayloadMap& id_payloads) {
113 DCHECK(CalledOnValidThread()); 110 DCHECK(CalledOnValidThread());
114 // TODO(dcheng): This should probably be a utility function somewhere... 111 // TODO(dcheng): This should probably be a utility function somewhere...
115 syncer::ModelTypePayloadMap type_payloads; 112 ModelTypePayloadMap type_payloads;
116 for (ObjectIdPayloadMap::const_iterator it = id_payloads.begin(); 113 for (ObjectIdPayloadMap::const_iterator it = id_payloads.begin();
117 it != id_payloads.end(); ++it) { 114 it != id_payloads.end(); ++it) {
118 syncer::ModelType model_type; 115 ModelType model_type;
119 if (!ObjectIdToRealModelType(it->first, &model_type)) { 116 if (!ObjectIdToRealModelType(it->first, &model_type)) {
120 DLOG(WARNING) << "Invalid object ID: " << ObjectIdToString(it->first); 117 DLOG(WARNING) << "Invalid object ID: " << ObjectIdToString(it->first);
121 continue; 118 continue;
122 } 119 }
123 type_payloads[model_type] = it->second; 120 type_payloads[model_type] = it->second;
124 } 121 }
125 FOR_EACH_OBSERVER( 122 FOR_EACH_OBSERVER(
126 SyncNotifierObserver, observers_, 123 SyncNotifierObserver, observers_,
127 OnIncomingNotification(type_payloads, 124 OnIncomingNotification(type_payloads, REMOTE_NOTIFICATION));
128 syncer::REMOTE_NOTIFICATION));
129 } 125 }
130 126
131 void InvalidationNotifier::OnNotificationsEnabled() { 127 void InvalidationNotifier::OnNotificationsEnabled() {
132 DCHECK(CalledOnValidThread()); 128 DCHECK(CalledOnValidThread());
133 FOR_EACH_OBSERVER(SyncNotifierObserver, observers_, 129 FOR_EACH_OBSERVER(SyncNotifierObserver, observers_,
134 OnNotificationsEnabled()); 130 OnNotificationsEnabled());
135 } 131 }
136 132
137 void InvalidationNotifier::OnNotificationsDisabled( 133 void InvalidationNotifier::OnNotificationsDisabled(
138 NotificationsDisabledReason reason) { 134 NotificationsDisabledReason reason) {
139 DCHECK(CalledOnValidThread()); 135 DCHECK(CalledOnValidThread());
140 FOR_EACH_OBSERVER(SyncNotifierObserver, observers_, 136 FOR_EACH_OBSERVER(SyncNotifierObserver, observers_,
141 OnNotificationsDisabled(reason)); 137 OnNotificationsDisabled(reason));
142 } 138 }
143 139
144 } // namespace syncer 140 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/notifier/invalidation_notifier.h ('k') | sync/notifier/invalidation_notifier_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698