Chromium Code Reviews
Help | Chromium Project | Sign in
(599)

Issue 10789018: aura: Add X11 host window management. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by reveman
Modified:
1 year, 3 months ago
CC:
chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, Elliot Glaysher, tfarina
Visibility:
Public.

Description

aura: Add X11 host window management.

BUG=124444
TEST=manual

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep ash switches alphabetized. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1910 lines, -22 lines) Lint Patch
M ash/ash.gyp View 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M ash/ash_switches.h View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M ash/ash_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
A ash/hostwm/OWNERS View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
A ash/hostwm/host_window_container.h View 1 chunk +47 lines, -0 lines 3 comments 2 errors Download
A ash/hostwm/host_window_container.cc View 1 chunk +108 lines, -0 lines 0 comments 1 errors Download
A ash/hostwm/host_window_manager.h View 1 chunk +51 lines, -0 lines 0 comments 2 errors Download
A ash/hostwm/host_window_manager.cc View 1 chunk +119 lines, -0 lines 0 comments 6 errors Download
M ash/shell.h View 3 chunks +9 lines, -0 lines 0 comments 0 errors Download
M ash/shell.cc View 5 chunks +26 lines, -0 lines 0 comments 1 errors Download
M ui/aura/aura.gyp View 2 chunks +7 lines, -0 lines 0 comments ? errors Download
A ui/aura/hostwm/OWNERS View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
A ui/aura/hostwm/host_window_delegate.h View 1 chunk +36 lines, -0 lines 0 comments 1 errors Download
A ui/aura/hostwm/host_window_delegate.cc View 1 chunk +25 lines, -0 lines 0 comments 1 errors Download
A ui/aura/hostwm/host_window_manager_client.h View 1 chunk +36 lines, -0 lines 0 comments 2 errors Download
A ui/aura/hostwm/host_window_manager_x11.h View 1 chunk +262 lines, -0 lines 0 comments 16 errors Download
A ui/aura/hostwm/host_window_manager_x11.cc View 1 chunk +1042 lines, -0 lines 0 comments 11 errors Download
M ui/aura/root_window.h View 3 chunks +9 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window.cc View 3 chunks +16 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window_host.h View 2 chunks +4 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window_host_linux.h View 3 chunks +3 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window_host_linux.cc View 10 chunks +73 lines, -22 lines 0 comments 4 errors Download
M ui/aura/root_window_host_mac.mm View 2 chunks +6 lines, -0 lines 0 comments ? errors Download
M ui/aura/root_window_host_win.h View 2 chunks +3 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window_host_win.cc View 2 chunks +10 lines, -0 lines 0 comments 0 errors Download
M ui/aura/root_window_observer.h View 2 chunks +5 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 6
reveman
Hi, this is Dana's and my current implementation of X11 host window management. Basically allowing ...
1 year, 9 months ago #1
Daniel Erat
This is a big, unexpected change. :-) What kind of timeframe were you hoping for ...
1 year, 9 months ago #2
danakj
To go top to bottom, I'd suggest: 1. ash/hostwm is the user-facing code, and shows ...
1 year, 9 months ago #3
Daniel Erat
+erg since this may have some overlap with the Linux work that he's doing. (This ...
1 year, 9 months ago #4
tfarina
http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_container.h File ash/hostwm/host_window_container.h (right): http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_container.h#newcode8 ash/hostwm/host_window_container.h:8: #include "base/compiler_specific.h" include basictypes.h as well. http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_container.h#newcode24 ash/hostwm/host_window_container.h:24: // ...
1 year, 9 months ago #5
Ben Goodger (Google)
1 year, 8 months ago #6
so, I think you should be able to achieve pretty much all of this from a
separate component that lives downstream of aura/ash and potentially in a
separate repo.

In ash, it looks like you're just hanging a few things off the shell. You can do
that from somewhere else in your process' main function.

In aura, again it seems like a bunch of x window configuration that you could
probably do from a downstream component.

As part of the win-aura work I am going to make it more easily possible to
replace the RootWindowHost, maybe that would work well for you in that you could
write your own that better supports this use case.

Look at how other components are set up. e.g. look at ash.gyp and how it depends
on other components. Look at the src/DEPS files and how it consumes components
from other repos.

At any rate i would like to keep this kind of thing out of aura/ash since it is
very platform/application specific.

-Ben
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6