aura: Add X11 host window management.

aura: Add X11 host window management.

BUG=124444
TEST=manual

[reveman, 2012-07-17 10:13:42]

Hi,

this is Dana's and my current implementation of X11 host window management.
Basically allowing ash to manage your X windows so that you can use chrome as
window manager on Linux and still run native X applications.

There's a few things in this CL that we probably want to land separately but I
thought I'd start by uploading the whole thing and we can then move things out
into new CLs as we find appropriate.

FYI, this CLs doesn't allow managed X windows to be rendered by the compositor.
It just does all necessary x11 window management. Rendering require that we
first land this: https://chromiumcodereview.appspot.com/10543125/

[Daniel Erat, 2012-07-17 18:23:57]

This is a big, unexpected change. :-)  What kind of timeframe were you
hoping for for the review?  Where would you recommend starting
(ui/aura/hostwm, ui/aura, then ash/hostwm)?

On Tue, Jul 17, 2012 at 3:13 AM,  <reveman@chromium.org> wrote:
> Reviewers: danakj, Daniel Erat, Ben Goodger (Google), sky,
>
> Message:
> Hi,
>
> this is Dana's and my current implementation of X11 host window management.
> Basically allowing ash to manage your X windows so that you can use chrome
> as
> window manager on Linux and still run native X applications.
>
> There's a few things in this CL that we probably want to land separately but
> I
> thought I'd start by uploading the whole thing and we can then move things
> out
> into new CLs as we find appropriate.
>
> FYI, this CLs doesn't allow managed X windows to be rendered by the
> compositor.
> It just does all necessary x11 window management. Rendering require that we
> first land this: https://chromiumcodereview.appspot.com/10543125/
>
> Description:
> aura: Add X11 host window management.
>
> BUG=124444
> TEST=manual
>
>
> Please review this at https://chromiumcodereview.appspot.com/10789018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M ash/ash.gyp
>   M ash/ash_switches.h
>   M ash/ash_switches.cc
>   A ash/hostwm/OWNERS
>   A ash/hostwm/host_window_container.h
>   A ash/hostwm/host_window_container.cc
>   A ash/hostwm/host_window_manager.h
>   A ash/hostwm/host_window_manager.cc
>   M ash/shell.h
>   M ash/shell.cc
>   M ui/aura/aura.gyp
>   A ui/aura/hostwm/OWNERS
>   A ui/aura/hostwm/host_window_delegate.h
>   A ui/aura/hostwm/host_window_delegate.cc
>   A ui/aura/hostwm/host_window_manager_client.h
>   A ui/aura/hostwm/host_window_manager_x11.h
>   A ui/aura/hostwm/host_window_manager_x11.cc
>   M ui/aura/root_window.h
>   M ui/aura/root_window.cc
>   M ui/aura/root_window_host.h
>   M ui/aura/root_window_host_linux.h
>   M ui/aura/root_window_host_linux.cc
>   M ui/aura/root_window_host_mac.mm
>   M ui/aura/root_window_host_win.h
>   M ui/aura/root_window_host_win.cc
>   M ui/aura/root_window_observer.h
>
>

[danakj, 2012-07-17 19:20:48]

To go top to bottom, I'd suggest:

1. ash/hostwm is the user-facing code, and shows the interaction of the x
window with Ash.
2. ui/aura is changes to support the code in ui/aura/hostwm
3. ui/aura/hostwm is the x-window-manager code. it's more nitty gritty
dealing with x events and all.

Depending what you like maybe the reverse would be nice. But this should
give you a good idea what you'll be looking at in each hopefully.


On Tue, Jul 17, 2012 at 2:23 PM, Daniel Erat <derat@chromium.org> wrote:

> This is a big, unexpected change. :-)  What kind of timeframe were you
> hoping for for the review?  Where would you recommend starting
> (ui/aura/hostwm, ui/aura, then ash/hostwm)?
>
> On Tue, Jul 17, 2012 at 3:13 AM,  <reveman@chromium.org> wrote:
> > Reviewers: danakj, Daniel Erat, Ben Goodger (Google), sky,
> >
> > Message:
> > Hi,
> >
> > this is Dana's and my current implementation of X11 host window
> management.
> > Basically allowing ash to manage your X windows so that you can use
> chrome
> > as
> > window manager on Linux and still run native X applications.
> >
> > There's a few things in this CL that we probably want to land separately
> but
> > I
> > thought I'd start by uploading the whole thing and we can then move
> things
> > out
> > into new CLs as we find appropriate.
> >
> > FYI, this CLs doesn't allow managed X windows to be rendered by the
> > compositor.
> > It just does all necessary x11 window management. Rendering require that
> we
> > first land this: https://chromiumcodereview.appspot.com/10543125/
> >
> > Description:
> > aura: Add X11 host window management.
> >
> > BUG=124444
> > TEST=manual
> >
> >
> > Please review this at https://chromiumcodereview.appspot.com/10789018/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> >   M ash/ash.gyp
> >   M ash/ash_switches.h
> >   M ash/ash_switches.cc
> >   A ash/hostwm/OWNERS
> >   A ash/hostwm/host_window_container.h
> >   A ash/hostwm/host_window_container.cc
> >   A ash/hostwm/host_window_manager.h
> >   A ash/hostwm/host_window_manager.cc
> >   M ash/shell.h
> >   M ash/shell.cc
> >   M ui/aura/aura.gyp
> >   A ui/aura/hostwm/OWNERS
> >   A ui/aura/hostwm/host_window_delegate.h
> >   A ui/aura/hostwm/host_window_delegate.cc
> >   A ui/aura/hostwm/host_window_manager_client.h
> >   A ui/aura/hostwm/host_window_manager_x11.h
> >   A ui/aura/hostwm/host_window_manager_x11.cc
> >   M ui/aura/root_window.h
> >   M ui/aura/root_window.cc
> >   M ui/aura/root_window_host.h
> >   M ui/aura/root_window_host_linux.h
> >   M ui/aura/root_window_host_linux.cc
> >   M ui/aura/root_window_host_mac.mm
> >   M ui/aura/root_window_host_win.h
> >   M ui/aura/root_window_host_win.cc
> >   M ui/aura/root_window_observer.h
> >
> >
>

[Daniel Erat, 2012-07-17 19:48:19]

+erg since this may have some overlap with the Linux work that he's doing.

(This is not my review; just including one nit that I noticed when glancing at
the first few files.)

https://chromiumcodereview.appspot.com/10789018/diff/1/ash/ash_switches.h
File ash/ash_switches.h (right):

https://chromiumcodereview.appspot.com/10789018/diff/1/ash/ash_switches.h#new...
ash/ash_switches.h:29: ASH_EXPORT extern const char
kAuraEnableHostWindowManagement[];
nit: see comment at beginning of list :-P

[tfarina, 2012-07-18 14:43:42]

http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_cont...
File ash/hostwm/host_window_container.h (right):

http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_cont...
ash/hostwm/host_window_container.h:8: #include "base/compiler_specific.h"
include basictypes.h as well.

http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_cont...
ash/hostwm/host_window_container.h:24: // Overridden from views::View:
nit: please, make these overrides private if possible!

http://codereview.chromium.org/10789018/diff/7001/ash/hostwm/host_window_cont...
ash/hostwm/host_window_container.h:36: private:
nit: indent one more space.

[Ben Goodger (Google), 2012-07-27 21:40:45]

so, I think you should be able to achieve pretty much all of this from a
separate component that lives downstream of aura/ash and potentially in a
separate repo.

In ash, it looks like you're just hanging a few things off the shell. You can do
that from somewhere else in your process' main function.

In aura, again it seems like a bunch of x window configuration that you could
probably do from a downstream component.

As part of the win-aura work I am going to make it more easily possible to
replace the RootWindowHost, maybe that would work well for you in that you could
write your own that better supports this use case.

Look at how other components are set up. e.g. look at ash.gyp and how it depends
on other components. Look at the src/DEPS files and how it consumes components
from other repos.

At any rate i would like to keep this kind of thing out of aura/ash since it is
very platform/application specific.

-Ben