Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 10787017: Fix missing tagging of stack value in finally block. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger
Modified:
8 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix missing tagging of stack value in finally block. R=yangguo@chromium.org BUG=chromium:137496 TEST=cctest/test-api/Regress137496 Committed: https://code.google.com/p/v8/source/detail?r=12096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-07-16 13:24:41 UTC) #1
Yang
8 years, 5 months ago (2012-07-16 13:29:37 UTC) #2
On 2012/07/16 13:24:41, Michael Starzinger wrote:

LGTM.

I remember to have written this code myself. How embarrassing... :S

Powered by Google App Engine
This is Rietveld 408576698