Issue 10787017: Fix missing tagging of stack value in finally block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10787017: Fix missing tagging of stack value in finally block. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger

Modified:
8 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix missing tagging of stack value in finally block. R=yangguo@chromium.org BUG=chromium:137496 TEST=cctest/test-api/Regress137496 Committed: https://code.google.com/p/v8/source/detail?r=12096

Created: 8 years, 5 months ago

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -0 lines)
M	src/arm/full-codegen-arm.cc	View	2 chunks	+2 lines, -0 lines	0 comments
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+2 lines, -0 lines	0 comments
M	src/mips/full-codegen-mips.cc	View	2 chunks	+2 lines, -0 lines	0 comments
M	src/x64/full-codegen-x64.cc	View	2 chunks	+2 lines, -0 lines	0 comments
M	test/cctest/test-api.cc	View	1 chunk	+14 lines, -0 lines	0 comments

Total messages: 2 (0 generated)

Yang

8 years, 5 months ago (2012-07-16 13:29:37 UTC) #2

On 2012/07/16 13:24:41, Michael Starzinger wrote:

LGTM.

I remember to have written this code myself. How embarrassing... :S