Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 10787017: Fix missing tagging of stack value in finally block. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4459 matching lines...) Expand 10 before | Expand all | Expand 10 after
4470 4470
4471 // Store pending message while executing finally block. 4471 // Store pending message while executing finally block.
4472 ExternalReference pending_message_obj = 4472 ExternalReference pending_message_obj =
4473 ExternalReference::address_of_pending_message_obj(isolate()); 4473 ExternalReference::address_of_pending_message_obj(isolate());
4474 __ Load(rdx, pending_message_obj); 4474 __ Load(rdx, pending_message_obj);
4475 __ push(rdx); 4475 __ push(rdx);
4476 4476
4477 ExternalReference has_pending_message = 4477 ExternalReference has_pending_message =
4478 ExternalReference::address_of_has_pending_message(isolate()); 4478 ExternalReference::address_of_has_pending_message(isolate());
4479 __ Load(rdx, has_pending_message); 4479 __ Load(rdx, has_pending_message);
4480 __ Integer32ToSmi(rdx, rdx);
4480 __ push(rdx); 4481 __ push(rdx);
4481 4482
4482 ExternalReference pending_message_script = 4483 ExternalReference pending_message_script =
4483 ExternalReference::address_of_pending_message_script(isolate()); 4484 ExternalReference::address_of_pending_message_script(isolate());
4484 __ Load(rdx, pending_message_script); 4485 __ Load(rdx, pending_message_script);
4485 __ push(rdx); 4486 __ push(rdx);
4486 } 4487 }
4487 4488
4488 4489
4489 void FullCodeGenerator::ExitFinallyBlock() { 4490 void FullCodeGenerator::ExitFinallyBlock() {
4490 ASSERT(!result_register().is(rdx)); 4491 ASSERT(!result_register().is(rdx));
4491 ASSERT(!result_register().is(rcx)); 4492 ASSERT(!result_register().is(rcx));
4492 // Restore pending message from stack. 4493 // Restore pending message from stack.
4493 __ pop(rdx); 4494 __ pop(rdx);
4494 ExternalReference pending_message_script = 4495 ExternalReference pending_message_script =
4495 ExternalReference::address_of_pending_message_script(isolate()); 4496 ExternalReference::address_of_pending_message_script(isolate());
4496 __ Store(pending_message_script, rdx); 4497 __ Store(pending_message_script, rdx);
4497 4498
4498 __ pop(rdx); 4499 __ pop(rdx);
4500 __ SmiToInteger32(rdx, rdx);
4499 ExternalReference has_pending_message = 4501 ExternalReference has_pending_message =
4500 ExternalReference::address_of_has_pending_message(isolate()); 4502 ExternalReference::address_of_has_pending_message(isolate());
4501 __ Store(has_pending_message, rdx); 4503 __ Store(has_pending_message, rdx);
4502 4504
4503 __ pop(rdx); 4505 __ pop(rdx);
4504 ExternalReference pending_message_obj = 4506 ExternalReference pending_message_obj =
4505 ExternalReference::address_of_pending_message_obj(isolate()); 4507 ExternalReference::address_of_pending_message_obj(isolate());
4506 __ Store(pending_message_obj, rdx); 4508 __ Store(pending_message_obj, rdx);
4507 4509
4508 // Restore result register from stack. 4510 // Restore result register from stack.
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
4543 *context_length = 0; 4545 *context_length = 0;
4544 return previous_; 4546 return previous_;
4545 } 4547 }
4546 4548
4547 4549
4548 #undef __ 4550 #undef __
4549 4551
4550 } } // namespace v8::internal 4552 } } // namespace v8::internal
4551 4553
4552 #endif // V8_TARGET_ARCH_X64 4554 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698