Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 10787017: Fix missing tagging of stack value in finally block. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4527 matching lines...) Expand 10 before | Expand all | Expand 10 after
4538 ExternalReference pending_message_obj = 4538 ExternalReference pending_message_obj =
4539 ExternalReference::address_of_pending_message_obj(isolate()); 4539 ExternalReference::address_of_pending_message_obj(isolate());
4540 __ li(at, Operand(pending_message_obj)); 4540 __ li(at, Operand(pending_message_obj));
4541 __ lw(a1, MemOperand(at)); 4541 __ lw(a1, MemOperand(at));
4542 __ push(a1); 4542 __ push(a1);
4543 4543
4544 ExternalReference has_pending_message = 4544 ExternalReference has_pending_message =
4545 ExternalReference::address_of_has_pending_message(isolate()); 4545 ExternalReference::address_of_has_pending_message(isolate());
4546 __ li(at, Operand(has_pending_message)); 4546 __ li(at, Operand(has_pending_message));
4547 __ lw(a1, MemOperand(at)); 4547 __ lw(a1, MemOperand(at));
4548 __ SmiTag(a1);
4548 __ push(a1); 4549 __ push(a1);
4549 4550
4550 ExternalReference pending_message_script = 4551 ExternalReference pending_message_script =
4551 ExternalReference::address_of_pending_message_script(isolate()); 4552 ExternalReference::address_of_pending_message_script(isolate());
4552 __ li(at, Operand(pending_message_script)); 4553 __ li(at, Operand(pending_message_script));
4553 __ lw(a1, MemOperand(at)); 4554 __ lw(a1, MemOperand(at));
4554 __ push(a1); 4555 __ push(a1);
4555 } 4556 }
4556 4557
4557 4558
4558 void FullCodeGenerator::ExitFinallyBlock() { 4559 void FullCodeGenerator::ExitFinallyBlock() {
4559 ASSERT(!result_register().is(a1)); 4560 ASSERT(!result_register().is(a1));
4560 // Restore pending message from stack. 4561 // Restore pending message from stack.
4561 __ pop(a1); 4562 __ pop(a1);
4562 ExternalReference pending_message_script = 4563 ExternalReference pending_message_script =
4563 ExternalReference::address_of_pending_message_script(isolate()); 4564 ExternalReference::address_of_pending_message_script(isolate());
4564 __ li(at, Operand(pending_message_script)); 4565 __ li(at, Operand(pending_message_script));
4565 __ sw(a1, MemOperand(at)); 4566 __ sw(a1, MemOperand(at));
4566 4567
4567 __ pop(a1); 4568 __ pop(a1);
4569 __ SmiUntag(a1);
4568 ExternalReference has_pending_message = 4570 ExternalReference has_pending_message =
4569 ExternalReference::address_of_has_pending_message(isolate()); 4571 ExternalReference::address_of_has_pending_message(isolate());
4570 __ li(at, Operand(has_pending_message)); 4572 __ li(at, Operand(has_pending_message));
4571 __ sw(a1, MemOperand(at)); 4573 __ sw(a1, MemOperand(at));
4572 4574
4573 __ pop(a1); 4575 __ pop(a1);
4574 ExternalReference pending_message_obj = 4576 ExternalReference pending_message_obj =
4575 ExternalReference::address_of_pending_message_obj(isolate()); 4577 ExternalReference::address_of_pending_message_obj(isolate());
4576 __ li(at, Operand(pending_message_obj)); 4578 __ li(at, Operand(pending_message_obj));
4577 __ sw(a1, MemOperand(at)); 4579 __ sw(a1, MemOperand(at));
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
4614 *context_length = 0; 4616 *context_length = 0;
4615 return previous_; 4617 return previous_;
4616 } 4618 }
4617 4619
4618 4620
4619 #undef __ 4621 #undef __
4620 4622
4621 } } // namespace v8::internal 4623 } } // namespace v8::internal
4622 4624
4623 #endif // V8_TARGET_ARCH_MIPS 4625 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698