Issue 10781033: Insert missing write barrier in sliced string allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10781033: Insert missing write barrier in sliced string allocation. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Insert missing write barrier in sliced string allocation. BUG=v8:2237 TEST=test-heap/Regress2237 Committed: https://code.google.com/p/v8/source/detail?r=12127

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	src/objects-inl.h	View		1 chunk	+2 lines, -0 lines	1 comment	Download
	M	test/cctest/test-heap.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 5 months ago (2012-07-17 12:38:45 UTC) #2

LGTM (with one nit).

https://chromiumcodereview.appspot.com/10781033/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/10781033/diff/1/src/objects-inl.h#newc...
src/objects-inl.h:2440: WriteBarrierMode mode = UPDATE_WRITE_BARRIER;
Can we pass in the WriteBarrierMode as a parameter with a default value? This
would be in sync with the other setters.

Expand Messages | Collapse Messages