Insert missing write barrier in sliced string allocation.

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2419 matching lines @@
 
 
 String* SlicedString::parent() {
   return String::cast(READ_FIELD(this, kParentOffset));
 }
 
 
 void SlicedString::set_parent(String* parent) {
   ASSERT(parent->IsSeqString() || parent->IsExternalString());
   WRITE_FIELD(this, kParentOffset, parent);
+  WriteBarrierMode mode = UPDATE_WRITE_BARRIER;

[Michael Starzinger, 2012/07/17 12:38:45]

Can we pass in the WriteBarrierMode as a parameter with a default value? This
would be in sync with the other setters.

+  CONDITIONAL_WRITE_BARRIER(GetHeap(), this, kParentOffset, parent, mode);
 }
 
 
 SMI_ACCESSORS(SlicedString, offset, kOffsetOffset)
 
 
 String* ConsString::first() {
   return String::cast(READ_FIELD(this, kFirstOffset));
 }
 
@@ skipping 2872 matching lines @@
 #undef WRITE_UINT32_FIELD
 #undef READ_SHORT_FIELD
 #undef WRITE_SHORT_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_INL_H_