Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: src/objects-inl.h

Issue 10781033: Insert missing write barrier in sliced string allocation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 6dd2a99518753b694a64e44b9848d0c9713a4935..31ae7b72e2ba3edfee06d87db871543f96035276 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -2437,6 +2437,8 @@ String* SlicedString::parent() {
void SlicedString::set_parent(String* parent) {
ASSERT(parent->IsSeqString() || parent->IsExternalString());
WRITE_FIELD(this, kParentOffset, parent);
+ WriteBarrierMode mode = UPDATE_WRITE_BARRIER;
Michael Starzinger 2012/07/17 12:38:45 Can we pass in the WriteBarrierMode as a parameter
+ CONDITIONAL_WRITE_BARRIER(GetHeap(), this, kParentOffset, parent, mode);
}
« no previous file with comments | « no previous file | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698