Make the id used in IconMsg_DownloadFavicon unique

Added FaviconTabHelper::GetNextFaviconDownloadRequestId() such that the id used in IconMsg_DownloadFavicon is unique. 
Currently, the ids are not unique as multiple classes send IconMsg_DownloadFavicon messages each with a locally generated id. 
This is necessary for 10500015.

Bug=None
Test=Compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146397

[pkotwicz, 2012-07-09 23:58:49]

Changes as requested.
Added favicon_util to wrap sending IconMsg_DownloadFavicon

[stevenjb, 2012-07-10 15:30:15]

LGTM with nits

http://codereview.chromium.org/10765021/diff/2001/chrome/browser/favicon/favi...
File chrome/browser/favicon/favicon_util.cc (right):

http://codereview.chromium.org/10765021/diff/2001/chrome/browser/favicon/favi...
chrome/browser/favicon/favicon_util.cc:17: image_size));
nit: align image_size with new

http://codereview.chromium.org/10765021/diff/2001/chrome/browser/favicon/favi...
File chrome/browser/favicon/favicon_util.h (right):

http://codereview.chromium.org/10765021/diff/2001/chrome/browser/favicon/favi...
chrome/browser/favicon/favicon_util.h:14: 
We should put a brief class description here, e.g. "Utility class for common
favicon related code, used by FaviconTabHelper, LauncherFaviconLoader, etc."

[pkotwicz, 2012-07-10 21:12:49]

Ben for OWNERS

[Ben Goodger (Google), 2012-07-11 16:07:46]

lgtm

[commit-bot: I haz the power, 2012-07-11 20:21:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10765021/7002

[commit-bot: I haz the power, 2012-07-11 20:22:02]

Presubmit check for 10765021-7002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Do not use #pragma once in header files.
See http://www.chromium.org/developers/coding-style#TOC-File-headers
  chrome/browser/favicon/favicon_util.h

Presubmit checks took 1.6s to calculate.

[commit-bot: I haz the power, 2012-07-11 21:56:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10765021/7002

[commit-bot: I haz the power, 2012-07-11 21:56:14]

Presubmit check for 10765021-7002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Do not use #pragma once in header files.
See http://www.chromium.org/developers/coding-style#TOC-File-headers
  chrome/browser/favicon/favicon_util.h

Presubmit checks took 1.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-07-11 22:50:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10765021/15001

[commit-bot: I haz the power, 2012-07-11 22:55:56]

Try job failure for 10765021-15001 (retry) on mac_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-12 01:35:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10765021/16003

[commit-bot: I haz the power, 2012-07-12 01:40:15]

Try job failure for 10765021-16003 (retry) on mac_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-12 16:13:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10765021/7006

[commit-bot: I haz the power, 2012-07-12 16:21:11]

Try job failure for 10765021-7006 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-12 17:06:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10765021/12014

[commit-bot: I haz the power, 2012-07-12 18:27:40]

Change committed as 146397